set ibmcloud capi components to proper v1alpha4 version and properly reconcile infrastructure resource for ibmcloud #728
Conversation
relyt0925
changed the title
|
✔️ Deploy Preview for hypershift-docs ready! 🔨 Explore the source changes: 1087321 🔍 Inspect the deploy log: https://app.netlify.com/sites/hypershift-docs/deploys/61a7931b8f96630007de4b58 😎 Browse the preview: https://deploy-preview-728--hypershift-docs.netlify.app |
|
/hold requires #719 to merge then rebase |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
|
||
| // reconciliation strips TypeMeta. We repopulate the static values since they are necessary for | ||
| // downstream reconciliation of the CAPI Cluster resource. | ||
| awsCluster.TypeMeta = metav1.TypeMeta{ |
There was a problem hiding this comment.
if this is being stripped how is this working atm though?
There was a problem hiding this comment.
it's not working for IBM Cloud. It only works for AWS because it happens to be at v1beta1
| // downstream reconciliation of the CAPI Cluster resource. | ||
| awsCluster.TypeMeta = metav1.TypeMeta{ | ||
| Kind: "AWSCluster", | ||
| APIVersion: capiawsv1.GroupVersion.String(), |
There was a problem hiding this comment.
It actually looks fine in my current cluster
infrastructureRef:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AWSCluster
name: agl
namespace: clusters-agl
There was a problem hiding this comment.
We use a gvk find previously
There was a problem hiding this comment.
it always matches v1beta1 if you use gvk find and doesn't properly support multiple versions (AKA IBMCloud clusters being at v1alpha1 but AWS cluster CRDs being at v1beta1)
…reconcile infrastructure resource for ibmcloud
relyt0925
force-pushed
the
ibm-cloud-fixes
branch
from
c17f8a2 to
c52b5d0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, relyt0925 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Since openshift#728 and openshift#719 the None platform support added via openshift#630 is broken, since there is no infraCR for None platform
Since openshift#728 and openshift#719 the None platform support added via openshift#630 is broken, since there is no infraCR for None platform
Since openshift#728 and openshift#719 the None platform support added via openshift#630 is broken, since there is no infraCR for None platform
Since openshift#728 and openshift#719 the None platform support added via openshift#630 is broken, since there is no infraCR for None platform
Since openshift#728 and openshift#719 the None platform support added via openshift#630 is broken, since there is no infraCR for None platform
4 participants
the repo does not yet have a v1beta1 version. We need to keep it v1alpha4 for now
Fixes: