CORENET-6229: Use networking.advertiseAddress for CNO apiserver override for IBMCloud PlatformType - #6553
Conversation
…ride This tells the cluster network operator to use the HostedCluster Spec.Networking.APIServer.AdvertiseAddress and Port when connecting to the apiserver on clusters in IBM Cloud. This is needed so that OVN (and probably other components) does not try to use the external apiserver URLs, which might either be blocked or using named certificates.
|
@bradbehle: This pull request references CORENET-6229 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @bradbehle. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Test Resultse2e-aws
e2e-aks
|
|
/ok-to-test |
|
/approve |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradbehle, bryan-cox, rtheis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
e2e-aks is flaky at the moment due to a new test added yesterday. We are working to fix it though. |
|
/retest |
c22b726
into
openshift:main
What this PR does / why we need it:
This tells the cluster network operator to use the HostedCluster Spec.Networking.APIServer.AdvertiseAddress and Port when connecting to the apiserver on clusters in IBM Cloud. This is needed so that OVN (and probably other components) does not try to use the external apiserver URLs, which might either be blocked by firewall rules or using named certificates which OVN doesn't handle.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes # https://issues.redhat.com/browse/CORENET-6229
Checklist