Skip to content

CORENET-6229: Use networking.advertiseAddress for CNO apiserver override for IBMCloud PlatformType - #6553

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bradbehle:ovn-user-advertise-addr-ibmcloud
Aug 2, 2025
Merged

CORENET-6229: Use networking.advertiseAddress for CNO apiserver override for IBMCloud PlatformType#6553
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bradbehle:ovn-user-advertise-addr-ibmcloud

Conversation

@bradbehle

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This tells the cluster network operator to use the HostedCluster Spec.Networking.APIServer.AdvertiseAddress and Port when connecting to the apiserver on clusters in IBM Cloud. This is needed so that OVN (and probably other components) does not try to use the external apiserver URLs, which might either be blocked by firewall rules or using named certificates which OVN doesn't handle.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/CORENET-6229

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

…ride

This tells the cluster network operator to use the HostedCluster
Spec.Networking.APIServer.AdvertiseAddress and Port when connecting
to the apiserver on clusters in IBM Cloud.  This is needed so that
OVN (and probably other components) does not try to use the external
apiserver URLs, which might either be blocked or using named certificates.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2025
@openshift-ci-robot

Copy link
Copy Markdown

@bradbehle: This pull request references CORENET-6229 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
This tells the cluster network operator to use the HostedCluster Spec.Networking.APIServer.AdvertiseAddress and Port when connecting to the apiserver on clusters in IBM Cloud. This is needed so that OVN (and probably other components) does not try to use the external apiserver URLs, which might either be blocked by firewall rules or using named certificates which OVN doesn't handle.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # https://issues.redhat.com/browse/CORENET-6229

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from rtheis and sjenning July 31, 2025 06:06
@openshift-ci openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels Jul 31, 2025
@openshift-ci

openshift-ci Bot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

Hi @bradbehle. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csrwng

csrwng commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2025
@cwbotbot

cwbotbot commented Jul 31, 2025

Copy link
Copy Markdown

Test Results

e2e-aws

e2e-aks

@rtheis

rtheis commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@bryan-cox

Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025

@rtheis rtheis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rtheis

rtheis commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2025
@openshift-ci

openshift-ci Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradbehle, bryan-cox, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4882e8f and 2 for PR HEAD ae8dc35 in total

@rtheis

rtheis commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

/retest-required
/ok-to-test

@bryan-cox

Copy link
Copy Markdown
Member

e2e-aks is flaky at the moment due to a new test added yesterday. We are working to fix it though.

@rtheis

rtheis commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-bot
openshift-merge-bot Bot merged commit c22b726 into openshift:main Aug 2, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants