Skip to content

Run ensure network policy on azure - #6377

Closed
bryan-cox wants to merge 2 commits into
openshift:mainfrom
bryan-cox:run-EnsureNetworkPolicy-on-azure
Closed

Run ensure network policy on azure#6377
bryan-cox wants to merge 2 commits into
openshift:mainfrom
bryan-cox:run-EnsureNetworkPolicy-on-azure

Conversation

@bryan-cox

@bryan-cox bryan-cox commented Jul 3, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2025
@openshift-ci

openshift-ci Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bryan-cox

bryan-cox commented Jul 3, 2025

Copy link
Copy Markdown
Member Author

/test e2e-aks

@openshift-ci openshift-ci Bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Jul 3, 2025
@openshift-ci

openshift-ci Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added area/testing Indicates the PR includes changes for e2e testing approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jul 3, 2025
@bryan-cox

bryan-cox commented Jul 3, 2025

Copy link
Copy Markdown
Member Author

Branched from #6328 to try out a potential fix

@cwbotbot

cwbotbot commented Jul 3, 2025

Copy link
Copy Markdown

Test Results

e2e-aks

Failed Tests

Total failed tests: 114

  • TestAzureScheduler
  • TestAzureScheduler/EnsureHostedCluster
  • TestAzureScheduler/EnsureHostedCluster/EnsureAllContainersHavePullPolicyIfNotPresent
  • TestAzureScheduler/EnsureHostedCluster/EnsureAllContainersHaveTerminationMessagePolicyFallbackToLogsOnError
  • TestAzureScheduler/EnsureHostedCluster/EnsureAllRoutesUseHCPRouter

... and 109 more failed tests

@bryan-cox
bryan-cox force-pushed the run-EnsureNetworkPolicy-on-azure branch from 882ab6f to 3f9cadf Compare July 18, 2025 17:53
@bryan-cox

bryan-cox commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

/test e2e-aks

@bryan-cox

bryan-cox commented Jul 18, 2025

Copy link
Copy Markdown
Member Author

/test e2e-aks

Just want to see if they fail in the same way

@bryan-cox
bryan-cox force-pushed the run-EnsureNetworkPolicy-on-azure branch 2 times, most recently from 29c2359 to f959542 Compare July 31, 2025 11:20
@bryan-cox

bryan-cox commented Jul 31, 2025

Copy link
Copy Markdown
Member Author

/test e2e-aks

@bryan-cox
bryan-cox force-pushed the run-EnsureNetworkPolicy-on-azure branch from f959542 to fc4c11a Compare July 31, 2025 14:04
@bryan-cox

bryan-cox commented Jul 31, 2025

Copy link
Copy Markdown
Member Author

/test e2e-aks

@bryan-cox

bryan-cox commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks fc4c11a link true /test e2e-aks
ci/prow/e2e-aks-4-20 fc4c11a link true /test e2e-aks-4-20
ci/prow/e2e-aws fc4c11a link true /test e2e-aws
ci/prow/verify fc4c11a link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox

bryan-cox commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

/close

@openshift-ci openshift-ci Bot closed this Oct 15, 2025
@openshift-ci

openshift-ci Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

@bryan-cox: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

devguyio added a commit to devguyio/hypershift that referenced this pull request Nov 21, 2025
@devguyio @claude
docs: add NetworkPolicy e2e test specification for Azure
6c6b6dd 
Add detailed specification document for implementing NetworkPolicy e2e test on ARO HCP clusters.

This spec analyzes the failed PR openshift#6377 approach and outlines the correct implementation strategy for testing user-facing NetworkPolicy functionality in the guest cluster.

🤖 Generated with Claude Code (claude-sonnet-4-5@20250929) via /jira-solve CNTRLPLANE-1445

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bryan-cox @cwbotbot @enxebre