Skip to content

Infrastructure resource: Set controlPlaneTopology: External#610

Closed
alvaroaleman wants to merge 1 commit intoopenshift:mainfrom
alvaroaleman:cotrolplanetopolocy-external
Closed

Infrastructure resource: Set controlPlaneTopology: External#610
alvaroaleman wants to merge 1 commit intoopenshift:mainfrom
alvaroaleman:cotrolplanetopolocy-external

Conversation

@alvaroaleman
Copy link
Contributor

This allows to detect that a cluster is a hypershift cluster which is
for example needed for tests.

Related enhancement is in
openshift/enhancements@46da245#diff-1f93c9be7f93ed45d04551f345307ebc6d5e8cd41d65afb97feb324b51bb3848

/assign @csrwng

Ref https://issues.redhat.com/browse/HOSTEDCP-257

This allows to detect that a cluster is a hypershift cluster which is
for example needed for tests.

Related enhancement is in
openshift/enhancements@46da245#diff-1f93c9be7f93ed45d04551f345307ebc6d5e8cd41d65afb97feb324b51bb3848
@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for hypershift-docs canceled.

🔨 Explore the source changes: 46060d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/hypershift-docs/deploys/6179af4fd7ce4b000952ca83

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2021

@alvaroaleman we are currently broken when setting ControlPlaneTopology to External. We are waiting for this: openshift/cluster-ingress-operator#666

I am also changing it in this PR -> #539, but have not been able to merge because of the same reason

@alvaroaleman
Copy link
Contributor Author

ah ok, thanks for the heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants