OCPBUGS-54946, RHOCPPRIO-433: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs

[jparrill]

What this PR does / why we need it

• Manual backport of OCPBUGS-53261: Add validation to avoid conflicts between KubeAPI server and NamedCertificates SANs #5875
• Bumped Go version from 1.22.0 to 1.22.1 in go.mod

Which issue(s) this PR fixes

• #OCPBUGS-54946
• #RHOCPPRIO-433

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-53261, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-53261 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it

• Manual backport of OCPBUGS-53261: Add validation to avoid conflicts between KubeAPI server and NamedCertificates SANs #5875
• Bumped in go.mod Go version from 1.22.0 to 1.22.1

Which issue(s) this PR fixes

• #OCPBUGS-54946
• #RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-53261, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-53261 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references RHOCPPRIO-433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.z" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it

• Manual backport of OCPBUGS-53261: Add validation to avoid conflicts between KubeAPI server and NamedCertificates SANs #5875
• Bumped in go.mod Go version from 1.22.0 to 1.22.1

Which issue(s) this PR fixes

• #OCPBUGS-54946
• #RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-53261, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-53261 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references RHOCPPRIO-433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.z" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it

• Manual backport of OCPBUGS-53261: Add validation to avoid conflicts between KubeAPI server and NamedCertificates SANs #5875
• Bumped Go version from 1.22.0 to 1.22.1 in go.mod

Which issue(s) this PR fixes

• #OCPBUGS-54946
• #RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-54946, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-53261 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-53261 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
• bug has dependents

Requesting review from QA contact:
/cc @wewang58

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references RHOCPPRIO-433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.z" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it

• Manual backport of OCPBUGS-53261: Add validation to avoid conflicts between KubeAPI server and NamedCertificates SANs #5875
• Bumped Go version from 1.22.0 to 1.22.1 in go.mod

Which issue(s) this PR fixes

• #OCPBUGS-54946
• #RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jparrill]

/jira-refresh

[sjenning]

Another unit test flake on external network request 😒

/test unit

[sjenning]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c7d5828 and 2 for PR HEAD f789861 in total

[openshift-ci]

@jparrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	f789861	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jparrill: Jira Issue OCPBUGS-54946: All pull requests linked via external trackers have merged:

• openshift/hypershift#6091

Jira Issue OCPBUGS-54946 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it

• Manual backport of OCPBUGS-53261: Add validation to avoid conflicts between KubeAPI server and NamedCertificates SANs #5875
• Bumped Go version from 1.22.0 to 1.22.1 in go.mod

Which issue(s) this PR fixes

• #OCPBUGS-54946
• #RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202504282205.p0.g8655acb.assembly.stream.el9.
All builds following this will include this PR.

[jparrill]

/jira backport release-4.17

[openshift-ci-robot]

@jparrill: The following backport issues have been created:

• OCPBUGS-55500 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17

Details

In response to this:

/jira backport release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: #6091 failed to apply on top of branch "release-4.17":

Applying: OCPBUGS-53261: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs
Using index info to reconstruct a base tree...
M	control-plane-operator/controllers/hostedcontrolplane/pki/kas.go
M	go.mod
A	hack/workspace/go.work
M	hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go
Falling back to patching base and 3-way merge...
Auto-merging hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go
CONFLICT (content): Merge conflict in hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go
CONFLICT (modify/delete): hack/workspace/go.work deleted in HEAD and modified in OCPBUGS-53261: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs. Version OCPBUGS-53261: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs of hack/workspace/go.work left in tree.
Auto-merging go.mod
Auto-merging control-plane-operator/controllers/hostedcontrolplane/pki/kas.go
CONFLICT (content): Merge conflict in control-plane-operator/controllers/hostedcontrolplane/pki/kas.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-53261: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs

Details

In response to this:

@jparrill: The following backport issues have been created:

• OCPBUGS-55500 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.17

In response to this:

/jira backport release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.