Move CAPI resources in to target namespace - #6
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ironcladlou
reviewed
Jan 27, 2021
| serviceAccountName: capa-controller-manager | ||
| containers: | ||
| - args: | ||
| - --namespace={{ .Namespace }} |
Contributor
There was a problem hiding this comment.
Use downward API to eliminate templating?
ironcladlou
reviewed
Jan 27, 2021
| - /manager | ||
| args: | ||
| - --namespace=hypershift | ||
| - --namespace={{ .Namespace }} |
Contributor
There was a problem hiding this comment.
Use downward API to eliminate templating?
This consolidates namespacing topology. openshiftCluster and nodePools are treated as regular namespaced kubernetes resources which needs a namespace to exist. CAPI CRs and any control plane resource is created in a target Namespace.
Contributor
|
/lgtm |
zanetworker
pushed a commit
to zanetworker/hypershift
that referenced
this pull request
Sep 28, 2021
Use the OpenShift API service IP from InfraStatus
Kyl-Bempah
pushed a commit
to Kyl-Bempah/hypershift
that referenced
this pull request
Nov 14, 2023
parent a701ee3 author red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com> 1698935322 +0000 committer Kyl-Bempah <24903083+Kyl-Bempah@users.noreply.github.com> 1699984168 -0500 # This is a combination of 2 commits. # This is the 1st commit message: chore(deps): update rhtap references # This is the commit message openshift#2: Enable multi-arch builds Signed-off-by: Kyl-Bempah <24903083+Kyl-Bempah@users.noreply.github.com> # This is the commit message openshift#3: OCPBUGS-16079: No error for overlapping service network and API IP Fixes: OCPBUGS-16079 Ensure that the nodeport IP for the API Server does not conflict with the Service Network CIDR. # This is the commit message openshift#4: Stop exposing kas on 6443 private route service load balancer We want to remove the unncessary exposure of port 6443 externally, as this increases the used SG rules, which decreases our max number of HC per management aws account openshift#3139 We split the PR to roll out the HO first to all envs to make sure the haproxy in dataplane for newly created HCs don't point to a port 6443 that won't be exposed. # This is the commit message openshift#5: OCPBUGS-10423: Update regex validation for nodepool.spec.taints.value # This is the commit message openshift#6: HOSTEDCP-1278: Adjustment cluster-cidr,service-cidr to support dual-stack # This is the commit message openshift#7: KubeVirt: create the etcd encryption key secret, if missing To allow creating of KubeVirt hosted cluster using the hosted cluster API (rather than using the cli). When creating the hosted cluster using the cli, the cli also creates the secret. But when creating the hosted cluster using the hosted cluster API, the secret is not created. This PR changes hypershift so it now creates the etcd encryption key secret, if it is not already exist. Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
4 tasks
Closed
4 tasks
Nirshal
added a commit
to Nirshal/hypershift
that referenced
this pull request
Jul 9, 2026
Pin quay.io/konflux-ci/appstudio-utils to tag+digest format as required by Konflux policy. MintMaker (Renovate) will auto-bump the digest via weekly PRs when the :latest tag is updated. Add early validation for snapshot-name in extract-image to fail fast before e2e execution. Addresses CodeRabbit findings openshift#4 and openshift#6 on PR openshift#8602. CNTRLPLANE-3434 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates namespacing topology.
openshiftCluster and nodePools are treated as regular namespaced kubernetes resources which needs a namespace to exist.
CAPI CRs and any control plane resource are created in a target Namespace.