ARO-15695: test/e2e: run EnsureImageRegistryCapabilityDisabled on 4.18

[sjenning]

Hold for #5964 to merge.

Diff is large because I wrapped EnsureImageRegistryCapabilityDisabled in a t.Run()

cc @flavianmissi

Run /test e2e-aws-4-18 after dep merge and before moving out of draft.

[openshift-ci-robot]

@sjenning: This pull request references ARO-15695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Hold for #5964 to merge.

Diff is large because I wrapped EnsureImageRegistryCapabilityDisabled in a t.Run()

cc @flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@sjenning: This pull request references ARO-15695 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Hold for #5964 to merge.

Diff is large because I wrapped EnsureImageRegistryCapabilityDisabled in a t.Run()

cc @flavianmissi

Run /test e2e-aws-4-18 after dep merge and before moving out of draft.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sjenning]

/test e2e-aws-4-18

[sjenning]

/test verify

[flavianmissi]

looks like it didn't work? 🤔

Failed  === RUN   TestCreateClusterCustomConfig/Main
    util.go:218: Successfully waited for kubeconfig to be published for HostedCluster e2e-clusters-ctp8b/custom-config-v9txn in 0s
    util.go:235: Successfully waited for kubeconfig secret to have data in 0s
    util.go:281: Successfully waited for a successful connection to the guest API server in 0s
    util.go:2348: 
        Expected an error to have occurred.  Got:
            <nil>: nil
    --- FAIL: TestCreateClusterCustomConfig/Main (5.48s)

The line in question (2348) attempts to get the image-registry cluster operator and expects an error, which didn't happen. The registry operator pod is also up and running: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_hypershift/5984/pull-ci-openshift-hypershift-main-e2e-aws-4-18/1908298529105776640/artifacts/e2e-aws-4-18/hypershift-aws-run-e2e-external/artifacts/TestCreateClusterCustomConfig/namespaces/e2e-clusters-ctp8b-custom-config-v9txn/core/pods/ (assuming I'm looking at the right place).

Is it possible that even though all the relevant code was merged, the feature still does not work in 4.18? how? 🤔

I'll run a retest in case somehow the code was not in the payload.

/retest

[sjenning]

unrelated flakes

/override ci/prow/e2e-aks
/override ci/prow/e2e-aks-4-18

[openshift-ci]

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aks-4-18

Details

In response to this:

unrelated flakes

/override ci/prow/e2e-aks
/override ci/prow/e2e-aks-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jparrill]

/lgtm

[openshift-ci]

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sjenning]

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

[openshift-ci]

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.20.0-202504080239.p0.g00016a3.assembly.stream.el9.
All builds following this will include this PR.