Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Fixes kubevirt image cacher #4847

Merged
merged 1 commit into from
Oct 7, 2024
Merged

NO-JIRA: Fixes kubevirt image cacher #4847

merged 1 commit into from
Oct 7, 2024

Conversation

davidvossel
Copy link
Contributor

This fixes a regression to the kubevirt provider that was introduced sept 26th by some nodepool refactoring PRs, #4795 and #4823

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2024
@openshift-ci-robot
Copy link

@davidvossel: This pull request explicitly references no jira issue.

In response to this:

This fixes a regression to the kubevirt provider that was introduced sept 26th by some nodepool refactoring PRs, #4795 and #4823

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@davidvossel
Copy link
Contributor Author

/hold

I need to validate this with the extended kubevirt tests to make sure the issue is resolved.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@openshift-ci openshift-ci bot requested review from nirarg and sjenning October 3, 2024 15:54
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Oct 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Oct 3, 2024
@davidvossel
Copy link
Contributor Author

/test ci/prow/e2e-kubevirt-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

@davidvossel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aks
  • /test e2e-aws
  • /test e2e-aws-4-17
  • /test e2e-kubevirt-aws-ovn-reduced
  • /test images
  • /test security
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-metrics
  • /test e2e-azure-aks-ovn-conformance
  • /test e2e-conformance
  • /test e2e-kubevirt-aws-ovn
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test e2e-openstack
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-aws-4-17
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-security
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test ci/prow/e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@davidvossel
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

@davidvossel
Fixes kubevirt image cacher
cf44a03 
Signed-off-by: David Vossel <[email protected]>
@sjenning
Copy link
Contributor

sjenning commented Oct 5, 2024

/test e2e-aws

@davidvossel
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

@sjenning
Copy link
Contributor

sjenning commented Oct 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
@davidvossel
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

@davidvossel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 73f7964 into openshift:main Oct 7, 2024
16 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202410072040.p0.g73f7964.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirarg nirarg Awaiting requested review from nirarg

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidvossel @openshift-ci-robot @sjenning @openshift-bot