Skip to content

Conversation

@orenc1
Copy link
Contributor

@orenc1 orenc1 commented May 21, 2024

in #4044, the JiraComponent and Description have been removed from the cert rotation objects since the struct have been changed and these fields were no longer exist. Afterwards it has been turned out that these fields were moved to AdditionalAnnotations. This PR reinstates the dropped fields.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

in openshift#4044, the JiraComponent and Description have been removed from the cert rotation objects since the struct have been changed
and these fields were no longer exist. Afterwards it has been turned out that these fields were moved to AdditionalAnnotations.
This PR reinstates the dropped fields.

Signed-off-by: Oren Cohen <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2024
@openshift-ci-robot
Copy link

@orenc1: This pull request explicitly references no jira issue.

Details

In response to this:

in #4044, the JiraComponent and Description have been removed from the cert rotation objects since the struct have been changed and these fields were no longer exist. Afterwards it has been turned out that these fields were moved to AdditionalAnnotations. This PR reinstates the dropped fields.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@orenc1
Copy link
Contributor Author

orenc1 commented May 21, 2024

/cc @stevekuznetsov

@openshift-ci openshift-ci bot requested a review from stevekuznetsov May 21, 2024 17:16
@openshift-ci openshift-ci bot requested review from csrwng and hasueki May 21, 2024 17:17
@openshift-ci openshift-ci bot added area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release and removed do-not-merge/needs-area labels May 21, 2024
@stevekuznetsov
Copy link
Contributor

/lgtm

@stevekuznetsov
Copy link
Contributor

Thanks @orenc1

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@sjenning
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@sjenning
Copy link
Contributor

sjenning commented May 21, 2024

/test e2e-aws

flake on https://issues.redhat.com/browse/OCPBUGS-24400

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0dc5bc4 and 2 for PR HEAD 6507794 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2024

@orenc1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 6507794 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8d88dfe into openshift:main May 22, 2024
@orenc1 orenc1 deleted the reinstate_removed_certrotation_fields branch May 22, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants