-
Notifications
You must be signed in to change notification settings - Fork 435
NO-JIRA: Reinstate wrongly removed fields from cert rotation objects #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Reinstate wrongly removed fields from cert rotation objects #4070
Conversation
in openshift#4044, the JiraComponent and Description have been removed from the cert rotation objects since the struct have been changed and these fields were no longer exist. Afterwards it has been turned out that these fields were moved to AdditionalAnnotations. This PR reinstates the dropped fields. Signed-off-by: Oren Cohen <[email protected]>
|
@orenc1: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @stevekuznetsov |
|
/lgtm |
|
Thanks @orenc1 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
@orenc1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
in #4044, the
JiraComponentandDescriptionhave been removed from the cert rotation objects since the struct have been changed and these fields were no longer exist. Afterwards it has been turned out that these fields were moved toAdditionalAnnotations. This PR reinstates the dropped fields.What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist