[release-4.14] OCPBUGS-29000,OCPBUGS-28984,OCPBUGS-28985,OCPBUGS-28986,OCPBUGS-19956: Support Disconnected HCP by bryan-cox · Pull Request #3520 · openshift/hypershift

bryan-cox · 2024-02-05T14:29:21Z

What this PR does / why we need it:

Which issue(s) this PR fixes
Manual cherry pick

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

OCPBUGS-11939: Use the image metadata from any ICSP/IDMS in a management cluster Signed-off-by: Bryan Cox <brcox@redhat.com>

Adds functionality to support extracting image files into release-manifests/image-reference config directory when working in a disconnected environment in the ignition server. Also, now catches the error when extracting image references to the config directory. Signed-off-by: Bryan Cox <brcox@redhat.com>

Include the OpenShiftTrustedCABundle ConfigMap in the ignition server deployment. Signed-off-by: Bryan Cox <brcox@redhat.com>

Adds functionality to support extracting image files into release-manifests/image-reference config directory when working in a disconnected environment in the ignition server. Also, now catches the error when extracting image references to the config directory. Signed-off-by: Bryan Cox <brcox@redhat.com>

openshift-ci-robot · 2024-02-05T14:29:33Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-29000, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11939 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-28984, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18128 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-28985, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18460 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-28986, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18602 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-19956, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18879 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @elsapassaro

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Manual cherry pick

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-05T14:30:01Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

bryan-cox · 2024-02-05T14:30:30Z

This is a manual pick of #3064 which needed to be rebased.

bryan-cox · 2024-02-05T14:31:12Z

/test images
/test verify
/test unit
/test e2e-aws

openshift-ci-robot · 2024-02-05T14:31:35Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-29000, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11939 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-28984, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18128 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-28985, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18460 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-28986, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18602 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-19956, which is valid.

4 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18879 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
bug has dependents

Requesting review from QA contact:
/cc @elsapassaro

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Manual cherry pick

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-05T14:32:22Z

@bryan-cox: No presubmit jobs available for openshift/hypershift@rhtap/references/release-4.14

Details

In response to this:

/test images
/test verify
/test unit
/test e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-02-05T14:33:30Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-29000, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-11939 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-11939 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-28984, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18128 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-18128 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-28985, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18460 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-18460 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-28986, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18602 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-18602 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

This pull request references Jira Issue OCPBUGS-19956, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-18879 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-18879 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @elsapassaro

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Manual cherry pick

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-02-05T15:29:24Z

/approve
/lgtm

bryan-cox · 2024-02-05T18:28:13Z

/test e2e-aws

LiangquanLi930 · 2024-02-06T06:38:21Z

/lgtm

sjenning · 2024-02-06T14:22:57Z

/approve

openshift-ci · 2024-02-06T14:27:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jparrill, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LiangquanLi930 · 2024-02-06T17:51:39Z

/test e2e-kubevirt-aws-ovn

openshift-ci-robot · 2024-02-06T21:39:30Z

/retest-required

Remaining retests: 0 against base HEAD 6d15150 and 2 for PR HEAD aabad1b in total

openshift-ci-robot · 2024-02-07T01:29:52Z

/retest-required

Remaining retests: 0 against base HEAD 21824b2 and 1 for PR HEAD aabad1b in total

openshift-ci · 2024-02-07T06:28:50Z

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-02-07T06:32:55Z

@bryan-cox: Jira Issue OCPBUGS-29000: All pull requests linked via external trackers have merged:

openshift/hypershift#3520

Jira Issue OCPBUGS-29000 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-28984: All pull requests linked via external trackers have merged:

openshift/hypershift#3520

Jira Issue OCPBUGS-28984 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-28985: All pull requests linked via external trackers have merged:

openshift/hypershift#3520

Jira Issue OCPBUGS-28985 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-28986: All pull requests linked via external trackers have merged:

openshift/hypershift#3520

Jira Issue OCPBUGS-28986 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-19956: All pull requests linked via external trackers have merged:

openshift/hypershift#3520

Jira Issue OCPBUGS-19956 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes
Manual cherry pick

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2024-02-07T20:27:03Z

Fix included in accepted release 4.14.0-0.nightly-2024-02-07-120144

bryan-cox added 4 commits February 5, 2024 09:04

OCPBUGS-11939: Use img metadata in from ICSP/IDMS

db23631

OCPBUGS-11939: Use the image metadata from any ICSP/IDMS in a management cluster Signed-off-by: Bryan Cox <brcox@redhat.com>

OCPBUGS-18460: Include Trusted CA CM in Ign Server

cf56067

Include the OpenShiftTrustedCABundle ConfigMap in the ignition server deployment. Signed-off-by: Bryan Cox <brcox@redhat.com>

openshift-ci Bot requested review from LiangquanLi930 and elsapassaro February 5, 2024 14:29

openshift-ci Bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 5, 2024

bryan-cox mentioned this pull request Feb 5, 2024

[release-4.14] OCPBUGS-29000,OCPBUGS-28984,OCPBUGS-28985,OCPBUGS-28986,OCPBUGS-19956: Support Disconnected HCP #3064

Closed

bryan-cox marked this pull request as ready for review February 5, 2024 14:32

bryan-cox changed the base branch from rhtap/references/release-4.14 to release-4.14 February 5, 2024 14:33

openshift-ci Bot requested review from enxebre and sjenning February 5, 2024 14:41

openshift-ci Bot assigned jparrill Feb 5, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024

openshift-ci Bot assigned LiangquanLi930 Feb 6, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024

openshift-merge-bot Bot merged commit 15533d4 into openshift:release-4.14 Feb 7, 2024

bryan-cox deleted the support-disconnected-hcp-4.14 branch February 7, 2024 13:31

Uh oh!

Conversation

bryan-cox commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

openshift-ci Bot commented Feb 5, 2024

Uh oh!

bryan-cox commented Feb 5, 2024

Uh oh!

bryan-cox commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

openshift-ci Bot commented Feb 5, 2024

Uh oh!

openshift-ci-robot commented Feb 5, 2024

Uh oh!

jparrill commented Feb 5, 2024

Uh oh!

bryan-cox commented Feb 5, 2024

Uh oh!

LiangquanLi930 commented Feb 6, 2024

Uh oh!

sjenning commented Feb 6, 2024

Uh oh!

openshift-ci Bot commented Feb 6, 2024

Uh oh!

LiangquanLi930 commented Feb 6, 2024

Uh oh!

openshift-ci-robot commented Feb 6, 2024

Uh oh!

openshift-ci-robot commented Feb 7, 2024

Uh oh!

openshift-ci Bot commented Feb 7, 2024

Uh oh!

openshift-ci-robot commented Feb 7, 2024

Uh oh!

openshift-merge-robot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bryan-cox commented Feb 5, 2024 •

edited

Loading