WRKLDS-925: remove duplicate passing of kubeconfig into route-controller-manager

[atiratree]

What this PR does / why we need it:

openshift/cluster-openshift-controller-manager-operator#295 and openshift/route-controller-manager#28 refactoring introducing passing a kubeconfig by a flag and removed it from the config. To merge all of these changes we had to support both ways in hypershift #2674.

Now that all of these PRs are merged, we can remove the duplication and pass the kubeconfig only just by a flag. This is done here:

hypershift/control-plane-operator/controllers/hostedcontrolplane/routecm/deployment.go

Lines 102 to 103 in 4413eb8

	"--kubeconfig",
	path.Join(volumeMounts.Path(c.Name, routeOCMVolumeKubeconfig().Name), kas.KubeconfigKey),

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[atiratree]

@enxebre can you please take a look?

[enxebre]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@atiratree: This pull request references WRKLDS-925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

openshift/cluster-openshift-controller-manager-operator#295 and openshift/route-controller-manager#28 refactoring introducing passing a kubeconfig by a flag and removed it from the config. To merge all of these changes we had to support both ways in hypershift #2674.

Now that all of these PRs are merged, we can remove the duplication and pass the kubeconfig only just by a flag. This is done here:

hypershift/control-plane-operator/controllers/hostedcontrolplane/routecm/deployment.go

Lines 102 to 103 in 4413eb8

	"--kubeconfig",
	path.Join(volumeMounts.Path(c.Name, routeOCMVolumeKubeconfig().Name), kas.KubeconfigKey),

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ingvagabund]

/lgtm

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.15.0-202311301610.p0.ge027b03.assembly.stream for distgit hypershift.
All builds following this will include this PR.