OCPBUGS-7840: Untangle kas port

[enxebre]

What this PR does / why we need it:
With this change, existing HCs defaulting Networking.APIServer.Port to 443 will preserve current behaviour of overriding the kas endpoint in the guest cluster.
This is to avoid data plane rollouts that would result from changing the haproxy config.

New HCs wont default to 443 and they won't override the kas endpoint. Setting Networking.APIServer.Port to 443 by a consumer is still techincally possible but unrecommended.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[enxebre]

/test e2e-aws

[enxebre]

/test e2e-aws

[enxebre]

/hold

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	2f58b6b
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/64f5b04928b0ef00096f5edb
😎 Deploy Preview	https://deploy-preview-2964--hypershift-docs.netlify.app/reference/api
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[enxebre]

=== CONT TestNodePool/Main/TestNTOMachineConfigAppliedInPlace
nodepool_nto_machineconfig_test.go:158:
failed waiting for all pods in the NTO MachineConfig update verification DS to be ready: timed out waiting for the condition
Unexpected error:
<*errors.errorString | 0xc0002ffd10>:
timed out waiting for the condition
{
s: "timed out waiting for the condition",
}
occurred
=== RUN TestNodePool/Teardown

/e2e-kubevirt-aws-ovn

[openshift-ci-robot]

@enxebre: This pull request references Jira Issue OCPBUGS-7840, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
With this change, existing HCs defaulting Networking.APIServer.Port to 443 will preserve current behaviour of overriding the kas endpoint in the guest cluster.
This is to avoid rollouts that would result from changing the haproxy config.

New HCs wont default to 443 and they won't override the kas endpoint. Setting Networking.APIServer.Port to 443 by a consumer is still techincally possible but unrecommended.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/jira refresh

[openshift-ci-robot]

@enxebre: This pull request references Jira Issue OCPBUGS-7840, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csrwng]

/lgtm
/retest-required

[openshift-ci]

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-iks	4a5fb87	link	false	/test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks	4a5fb87	link	false	/test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@enxebre: This pull request references Jira Issue OCPBUGS-7840, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

Details

In response to this:

What this PR does / why we need it:
With this change, existing HCs defaulting Networking.APIServer.Port to 443 will preserve current behaviour of overriding the kas endpoint in the guest cluster.
This is to avoid data plane rollouts that would result from changing the haproxy config.

New HCs wont default to 443 and they won't override the kas endpoint. Setting Networking.APIServer.Port to 443 by a consumer is still techincally possible but unrecommended.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/test e2e-kubevirt-aws-ovn

[enxebre]

/hold cancel

[openshift-ci-robot]

@enxebre: Jira Issue OCPBUGS-7840: All pull requests linked via external trackers have merged:

• openshift/hypershift#2964

Jira Issue OCPBUGS-7840 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
With this change, existing HCs defaulting Networking.APIServer.Port to 443 will preserve current behaviour of overriding the kas endpoint in the guest cluster.
This is to avoid data plane rollouts that would result from changing the haproxy config.

New HCs wont default to 443 and they won't override the kas endpoint. Setting Networking.APIServer.Port to 443 by a consumer is still techincally possible but unrecommended.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929