-
Notifications
You must be signed in to change notification settings - Fork 433
Allow overriding pod security admission label #2886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding pod security admission label #2886
Conversation
Introduces an annotation to override the pod security admission label for hosted control plane namespaces. This is a follow up to openshift#2778 where the default PSA is now changed to 'Restricted'. For some consumers like IBM, this label may be too restrictive for other workloads they may want to run in the control plane namespace.
bryan-cox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@csrwng: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Revision 4cf0d02 was retested 3 times: holding |
|
KubeVirt e2e is broken at the moment and has been made optional. |
|
/override ci/prow/e2e-kubevirt-aws-ovn |
|
@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rtheis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, csrwng, rtheis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Introduces an annotation to override the pod security admission label for hosted control plane namespaces.
This is a follow up to #2778 where the default PSA is now changed to 'Restricted'. For some consumers like IBM, this label may be too restrictive for other workloads they may want to run in the control plane namespace.
Checklist