Skip to content

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Aug 8, 2023

What this PR does / why we need it:
Introduces an annotation to override the pod security admission label for hosted control plane namespaces.

This is a follow up to #2778 where the default PSA is now changed to 'Restricted'. For some consumers like IBM, this label may be too restrictive for other workloads they may want to run in the control plane namespace.

Checklist

  • Subject and description added to both, commit and PR.

Introduces an annotation to override the pod security admission label for
hosted control plane namespaces.

This is a follow up to openshift#2778
where the default PSA is now changed to 'Restricted'. For some consumers
like IBM, this label may be too restrictive for other workloads they may
want to run in the control plane namespace.
@openshift-ci openshift-ci bot requested review from enxebre and hasueki August 8, 2023 19:49
@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Aug 8, 2023
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4072623 and 2 for PR HEAD 4cf0d02 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 844b26a and 1 for PR HEAD 4cf0d02 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d806b54 and 0 for PR HEAD 4cf0d02 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 4cf0d02 link false /test e2e-ibmcloud-iks
ci/prow/e2e-kubevirt-aws-ovn 4cf0d02 link true /test e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 4cf0d02 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2023
@bryan-cox
Copy link
Member

KubeVirt e2e is broken at the moment and has been made optional.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2023
@csrwng
Copy link
Contributor Author

csrwng commented Aug 11, 2023

/override ci/prow/e2e-kubevirt-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@csrwng: Overrode contexts on behalf of csrwng: ci/prow/e2e-kubevirt-aws-ovn

Details

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, csrwng, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8adef4c into openshift:main Aug 11, 2023
@csrwng csrwng deleted the override_psa_label branch November 15, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants