WRKLDS-730: use default /healthz path for readiness probe in OCM and RCM

[atiratree]

What this PR does / why we need it:

openshift-controller-manager deployment uses /healthz endpoint https://github.com/openshift/cluster-openshift-controller-manager-operator/blob/master/bindata/v3.11.0/openshift-controller-manager/deploy.yaml even though /healhtz/ready is available, there does not seem to be good reason for using it: https://github.com/openshift/openshift-controller-manager/blob/80c4923e0b2014ec8b8a6845c21078e6cc036f91/pkg/cmd/controller/standalone_apiserver.go#L75

With a switch to library-go in openshift/route-controller-manager#28 (and k8s.io/apiserver) /healthz/ready endpoint is no longer available: https://github.com/kubernetes/apiserver/blob/d2172f30e1af3782a7124e21b8cb4676fc789acc/pkg/server/config.go#L412, so we need to update endpoints here accordingly

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes https://issues.redhat.com/browse/WRKLDS-730 and followup to #2674

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[atiratree]

/retest

[atiratree]

/retest

[atiratree]

/retest

[atiratree]

/retest

[csrwng]

/approve

[bryan-cox]

/retitle WRKLDS-730: use default /healthz path for readiness probe in OCM and RCM

[openshift-ci-robot]

@atiratree: This pull request references WRKLDS-730 which is a valid jira issue.

Details

In response to this:

What this PR does / why we need it:

openshift-controller-manager deployment uses /healthz endpoint https://github.com/openshift/cluster-openshift-controller-manager-operator/blob/master/bindata/v3.11.0/openshift-controller-manager/deploy.yaml even though /healhtz/ready is available, there does not seem to be good reason for using it: https://github.com/openshift/openshift-controller-manager/blob/80c4923e0b2014ec8b8a6845c21078e6cc036f91/pkg/cmd/controller/standalone_apiserver.go#L75

With a switch to library-go in openshift/route-controller-manager#28 (and k8s.io/apiserver) /healthz/ready endpoint is no longer available: https://github.com/kubernetes/apiserver/blob/d2172f30e1af3782a7124e21b8cb4676fc789acc/pkg/server/config.go#L412, so we need to update endpoints here accordingly

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes https://issues.redhat.com/browse/WRKLDS-730 and followup to #2674

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bryan-cox]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, bryan-cox, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[csrwng]

/override "Pipelines as Code CI / hypershift-operator-main-on-pull-request"
/override "Pipelines as Code CI"

[openshift-ci]

@csrwng: Overrode contexts on behalf of csrwng: Pipelines as Code CI, Pipelines as Code CI / hypershift-operator-main-on-pull-request

Details

In response to this:

/override "Pipelines as Code CI / hypershift-operator-main-on-pull-request"
/override "Pipelines as Code CI"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fc42313 and 2 for PR HEAD 49a08a8 in total

[atiratree]

/test e2e-aws

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.