Skip to content

Switch API documentation to v1beta1 #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 27, 2023
Merged

Switch API documentation to v1beta1 #2056

openshift-merge-robot merged 1 commit into from
Jan 27, 2023

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Jan 18, 2023

What this PR does / why we need it:
Use v1beta1 as the documented API documentation instead of v1alpha1 which is deprecated

Checklist

  • Subject and description added to both, commit and PR.

@openshift-ci openshift-ci bot requested review from enxebre and sjenning January 18, 2023 21:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@netlify
Copy link

netlify bot commented Jan 18, 2023 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 73bce05
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/63d4292232c51c00081adcdd
😎 Deploy Preview https://deploy-preview-2056--hypershift-docs.netlify.app/reference/api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@enxebre
Copy link
Member

enxebre commented Jan 20, 2023

sweet, thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2023

/retest-required

Remaining retests: 0 against base HEAD 0b0a02e and 2 for PR HEAD ae41915 in total

@sjenning
Copy link
Contributor

sjenning commented Jan 20, 2023

needs a make update I think

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2023

/retest-required

Remaining retests: 0 against base HEAD ad13f5c and 1 for PR HEAD ae41915 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2023

/retest-required

Remaining retests: 0 against base HEAD 4393de2 and 0 for PR HEAD ae41915 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2023

/hold

Revision ae41915 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2023
@csrwng csrwng force-pushed the api_doc branch 2 times, most recently from 88c31f7 to 331813a Compare January 26, 2023 16:06
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2023
@csrwng
Copy link
Contributor Author

csrwng commented Jan 26, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2023
@sjenning
Copy link
Contributor

sjenning commented Jan 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2023 •
edited
Loading

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 3ff6853 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 3ff6853 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2023
@csrwng
Switch API documentation to v1beta1
73bce05 
Use v1beta1 as the documented API documentation instead of v1alpha1 which is deprecated
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2023
@sjenning
Copy link
Contributor

sjenning commented Jan 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3cd9cd5 into openshift:main Jan 27, 2023
@a-dsouza a-dsouza mentioned this pull request Apr 5, 2023
Closed
4 tasks
@csrwng csrwng deleted the api_doc branch July 14, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

@enxebre enxebre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csrwng @enxebre @openshift-ci-robot @sjenning @openshift-merge-robot