Skip to content

Conversation

@sjenning
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from csrwng and enxebre November 30, 2022 02:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2022
@csrwng
Copy link
Contributor

csrwng commented Nov 30, 2022

@hasueki @relyt0925 ptal
lgtm

@sjenning
Copy link
Contributor Author

/hold
All tests failed unable to connect to the guest KAS. Not sure if this works as OSD claimed.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit d5fb5ad
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6388fc807a0df20008372cec
😎 Deploy Preview https://deploy-preview-1905--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sjenning
Copy link
Contributor Author

sjenning commented Dec 1, 2022

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@sjenning
Copy link
Contributor Author

sjenning commented Dec 2, 2022

/retest-required

1 similar comment
@sjenning
Copy link
Contributor Author

sjenning commented Dec 2, 2022

/retest-required

Copy link
Contributor

@hasueki hasueki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold Let me double check with our networking team on this

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@hasueki
Copy link
Contributor

hasueki commented Dec 20, 2022

Thank you for your patience! I think we are good here!

@hasueki
Copy link
Contributor

hasueki commented Dec 20, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@enxebre
Copy link
Member

enxebre commented Dec 20, 2022

/hold
to make sure it doesn't trigger CI before #1970 gets merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@enxebre
Copy link
Member

enxebre commented Dec 20, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2022
@csrwng
Copy link
Contributor

csrwng commented Dec 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9c650d8 and 2 for PR HEAD d5fb5ad in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dc251d8 and 1 for PR HEAD d5fb5ad in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 214bd62 and 0 for PR HEAD d5fb5ad in total

@openshift-ci-robot
Copy link

/hold

Revision d5fb5ad was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2022
@sjenning
Copy link
Contributor Author

sjenning commented Jan 5, 2023

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@sjenning
Copy link
Contributor Author

sjenning commented Jan 5, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@hasueki
Copy link
Contributor

hasueki commented Jan 5, 2023

This egress policy was blocking DNS traffic when installed on vanilla kube mgmt clusters.

E0105 18:18:14.955429       1 run.go:74] "command failed" err="context deadline exceeded"
W0105 18:18:14.955429       1 logging.go:59] [core] [Channel #1 SubChannel #2] grpc: addrConn.createTransport failed to connect to {
  "Addr": "etcd-prtesting412-82267746-client:2379",
  "ServerName": "etcd-prtesting412-82267746-client",
  "Attributes": null,
  "BalancerAttributes": null,
  "Type": 0,
  "Metadata": null
}. Err: connection error: desc = "transport: Error while dialing dial tcp: lookup etcd-prtesting412-82267746-client: i/o timeout"

Altering it to..

MatchLabels: map[string]string{
    "kubernetes.io/metadata.name": "kube-system",
},

.. seems to work for vanilla kube.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@sjenning
Copy link
Contributor Author

sjenning commented Jan 5, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@csrwng
Copy link
Contributor

csrwng commented Jan 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

@sjenning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-e2e-kubevirt-azure-ovn d5fb5ad link false /test kubevirt-e2e-kubevirt-azure-ovn
ci/prow/capi-provider-agent-sanity d5fb5ad link false /test capi-provider-agent-sanity
ci/prow/kubevirt-e2e-kubevirt-aws-ovn 0e8d515 link false /test kubevirt-e2e-kubevirt-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants