-
Notifications
You must be signed in to change notification settings - Fork 435
add KAS egress network policy #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hasueki @relyt0925 ptal |
|
/hold |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/hold cancel |
|
/retest-required |
1 similar comment
|
/retest-required |
hasueki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold Let me double check with our networking team on this
|
Thank you for your patience! I think we are good here! |
|
/hold cancel |
|
/hold |
|
/hold cancel |
|
/lgtm |
|
/hold Revision d5fb5ad was retested 3 times: holding |
|
/hold cancel |
|
/hold |
|
This egress policy was blocking DNS traffic when installed on vanilla kube mgmt clusters. Altering it to.. .. seems to work for vanilla kube. |
|
/hold cancel |
|
/lgtm |
|
@sjenning: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/HOSTEDCP-645