-
Notifications
You must be signed in to change notification settings - Fork 435
Remove KubeletConfig & ContainerRuntimeConfig CRDs #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removes kubeletconfigs.machineconfiguration.openshift.io and controllerconfigs.machineconfiguration.openshift.io from the HyperShift cluster
| "0000_50_cluster-ingress-operator_02-deployment-ibm-cloud-managed.yaml", | ||
| "0000_70_cluster-network-operator_02_rbac.yaml", | ||
| "0000_70_cluster-network-operator_03_deployment-ibm-cloud-managed.yaml", | ||
| "0000_80_machine-config-operator_01_containerruntimeconfig.crd.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csrwng can we just stop including this in the ibm-cloud-managed profile?
and also exclude.release.openshift.io/internal-openshift-hosted for future profile consumption?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll need to be addressed in https://issues.redhat.com/browse/HOSTEDCP-373
|
/test e2e-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/lgtm |
|
@bryan-cox: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes HOSTEDCP-516
Checklist