Skip to content

Conversation

@bryan-cox
Copy link
Member

What this PR does / why we need it:

  • Prevents kubeletconfigs.machineconfiguration.openshift.io and controllerconfigs.machineconfiguration.openshift.io CRDs from being created in the HyperShift cluster

Which issue(s) this PR fixes:
Fixes HOSTEDCP-516

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Removes kubeletconfigs.machineconfiguration.openshift.io and controllerconfigs.machineconfiguration.openshift.io from the HyperShift cluster
@openshift-ci openshift-ci bot requested review from csrwng and sjenning September 30, 2022 19:04
"0000_50_cluster-ingress-operator_02-deployment-ibm-cloud-managed.yaml",
"0000_70_cluster-network-operator_02_rbac.yaml",
"0000_70_cluster-network-operator_03_deployment-ibm-cloud-managed.yaml",
"0000_80_machine-config-operator_01_containerruntimeconfig.crd.yaml",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csrwng can we just stop including this in the ibm-cloud-managed profile?
and also exclude.release.openshift.io/internal-openshift-hosted for future profile consumption?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to be addressed in https://issues.redhat.com/browse/HOSTEDCP-373

@enxebre
Copy link
Member

enxebre commented Oct 5, 2022

/test e2e-aws
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@enxebre
Copy link
Member

enxebre commented Oct 10, 2022

/test e2e-aws

@sjenning
Copy link
Contributor

/lgtm
last e2e flaked on #1798
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 99c0cc3 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 77e5c21 and 2 for PR HEAD 99c0cc3 in total

@openshift-merge-robot openshift-merge-robot merged commit f1b8426 into openshift:main Oct 12, 2022
@bryan-cox bryan-cox deleted the HOSTEDCP-516 branch October 12, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants