Skip to content

Update ibmcloud#1254

Closed
mkumatag wants to merge 2 commits intoopenshift:mainfrom
mkumatag:update_ibmcloud
Closed

Update ibmcloud#1254
mkumatag wants to merge 2 commits intoopenshift:mainfrom
mkumatag:update_ibmcloud

Conversation

@mkumatag
Copy link
Copy Markdown
Member

What this PR does / why we need it:

Update the go update deps for CAPIBM

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci Bot requested review from enxebre and ironcladlou April 11, 2022 16:34
@mkumatag
Copy link
Copy Markdown
Member Author

/assign @enxebre

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkumatag
To complete the pull request process, please ask for approval from enxebre after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Copy Markdown
Member Author

/retest

@mkumatag mkumatag mentioned this pull request Apr 11, 2022
4 tasks
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 11, 2022

@mkumatag: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Apr 12, 2022

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@mkumatag
Copy link
Copy Markdown
Member Author

closing this as its already taken care part of #1255

@mkumatag mkumatag closed this Apr 19, 2022
@mkumatag mkumatag deleted the update_ibmcloud branch April 19, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants