Skip to content

Conversation

@jparrill
Copy link
Contributor

What this PR does / why we need it

This PR addresses scheme compatibility issues in backup operations by:

  1. Updating hypershift/api dependency from v0.0.0-20250108163049-830af0531d12 to v0.0.0-20251024225833-7a63e46b0d15 (latest main)
  2. Adding dependency validation infrastructure to prevent future stale dependency issues
  3. Updating Go version from 1.24.0 to 1.24.4 for latest patches and improvements

The main issue was that outdated hypershift API schemas were causing backup operations to fail when processing HyperShift resources. The updated dependency includes the latest schema definitions and fixes compatibility issues.

Additionally, this PR introduces automated dependency validation tests in tests/integration/dependencies/ that will alert when the hypershift/api dependency becomes too old (>30 days), preventing this issue from recurring.

Which issue(s) this PR fixes

Fixes https://issues.redhat.com/browse/OCPBUGS-63573

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Testing

  • All existing tests pass
  • New dependency validation test passes and confirms hypershift/api is up-to-date
  • Project builds successfully with updated dependencies
  • Integration test infrastructure is in place for future dependency monitoring

Additional Notes

The dependency validation test can be run independently:

go test ./tests/integration/dependencies -v

This test will fail if hypershift/api dependency is older than 30 days, providing early warning for scheme compatibility issues.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 27, 2025
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-63573, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it

This PR addresses scheme compatibility issues in backup operations by:

  1. Updating hypershift/api dependency from v0.0.0-20250108163049-830af0531d12 to v0.0.0-20251024225833-7a63e46b0d15 (latest main)
  2. Adding dependency validation infrastructure to prevent future stale dependency issues
  3. Updating Go version from 1.24.0 to 1.24.4 for latest patches and improvements

The main issue was that outdated hypershift API schemas were causing backup operations to fail when processing HyperShift resources. The updated dependency includes the latest schema definitions and fixes compatibility issues.

Additionally, this PR introduces automated dependency validation tests in tests/integration/dependencies/ that will alert when the hypershift/api dependency becomes too old (>30 days), preventing this issue from recurring.

Which issue(s) this PR fixes

Fixes https://issues.redhat.com/browse/OCPBUGS-63573

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Testing

  • All existing tests pass
  • New dependency validation test passes and confirms hypershift/api is up-to-date
  • Project builds successfully with updated dependencies
  • Integration test infrastructure is in place for future dependency monitoring

Additional Notes

The dependency validation test can be run independently:

go test ./tests/integration/dependencies -v

This test will fail if hypershift/api dependency is older than 30 days, providing early warning for scheme compatibility issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from devguyio and kaovilai October 27, 2025 08:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
…lidation

- Update github.com/openshift/hypershift/api to latest main (v0.0.0-20251024225833-7a63e46b0d15)
- Add scalable integration test infrastructure in tests/integration/
- Implement commit-hash based dependency validation against upstream repositories
- Use configurable map-based approach for monitoring multiple dependencies
- Validate dependencies are up-to-date with upstream main branches (not time-based)
- Update vendor directory and all related dependencies

The dependency validation system:
- Compares commit hashes from pseudo-versions against upstream main
- Uses watchedDependencies map for easy addition of new dependencies
- Provides detailed feedback with specific commit hashes and update commands
- Eliminates time-zone and clock-drift issues from previous approaches

This resolves reported scheme failures in backup operations by ensuring
critical dependencies stay current with upstream changes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
@jparrill
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 27, 2025
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-63573, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025
@kaovilai
Copy link
Member

will green after openshift/release#70699

also in the future we can refactor so go version is defined in this repo rather than release.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f8f37e2 and 2 for PR HEAD 3883308 in total

@kaovilai
Copy link
Member

/retest

1 similar comment
@jparrill
Copy link
Contributor Author

/retest

@jparrill jparrill force-pushed the OCPBUGS-63573 branch 2 times, most recently from d8cc42a to 82a967b Compare October 28, 2025 16:45
Updates container build images to use Go 1.24 instead of 1.23:
- Dockerfile: Update to rhel-9-release-golang-1.24-openshift-4.20
- Dockerfile.oadp: Update to rhel_9_golang_1.24

This aligns container builds with the Go 1.24.4 version used in go.mod.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kaovilai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c528b0 into openshift:main Oct 28, 2025
7 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-63573: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-63573 has not been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it

This PR addresses scheme compatibility issues in backup operations by:

  1. Updating hypershift/api dependency from v0.0.0-20250108163049-830af0531d12 to v0.0.0-20251024225833-7a63e46b0d15 (latest main)
  2. Adding dependency validation infrastructure to prevent future stale dependency issues
  3. Updating Go version from 1.24.0 to 1.24.4 for latest patches and improvements

The main issue was that outdated hypershift API schemas were causing backup operations to fail when processing HyperShift resources. The updated dependency includes the latest schema definitions and fixes compatibility issues.

Additionally, this PR introduces automated dependency validation tests in tests/integration/dependencies/ that will alert when the hypershift/api dependency becomes too old (>30 days), preventing this issue from recurring.

Which issue(s) this PR fixes

Fixes https://issues.redhat.com/browse/OCPBUGS-63573

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Testing

  • All existing tests pass
  • New dependency validation test passes and confirms hypershift/api is up-to-date
  • Project builds successfully with updated dependencies
  • Integration test infrastructure is in place for future dependency monitoring

Additional Notes

The dependency validation test can be run independently:

go test ./tests/integration/dependencies -v

This test will fail if hypershift/api dependency is older than 30 days, providing early warning for scheme compatibility issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants