-
Notifications
You must be signed in to change notification settings - Fork 13
OCPBUGS-63573: Fix scheme compatibility issues by updating hypershift/api dependency #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jparrill: This pull request references Jira Issue OCPBUGS-63573, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…lidation - Update github.com/openshift/hypershift/api to latest main (v0.0.0-20251024225833-7a63e46b0d15) - Add scalable integration test infrastructure in tests/integration/ - Implement commit-hash based dependency validation against upstream repositories - Use configurable map-based approach for monitoring multiple dependencies - Validate dependencies are up-to-date with upstream main branches (not time-based) - Update vendor directory and all related dependencies The dependency validation system: - Compares commit hashes from pseudo-versions against upstream main - Uses watchedDependencies map for easy addition of new dependencies - Provides detailed feedback with specific commit hashes and update commands - Eliminates time-zone and clock-drift issues from previous approaches This resolves reported scheme failures in backup operations by ensuring critical dependencies stay current with upstream changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
6cbced9 to
be54017
Compare
|
/jira refresh |
|
@jparrill: This pull request references Jira Issue OCPBUGS-63573, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
will green after openshift/release#70699 also in the future we can refactor so go version is defined in this repo rather than release. |
3883308 to
744ad02
Compare
|
/retest |
1 similar comment
|
/retest |
d8cc42a to
82a967b
Compare
Updates container build images to use Go 1.24 instead of 1.23: - Dockerfile: Update to rhel-9-release-golang-1.24-openshift-4.20 - Dockerfile.oadp: Update to rhel_9_golang_1.24 This aligns container builds with the Go 1.24.4 version used in go.mod. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
82a967b to
c34125b
Compare
|
@jparrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jparrill: Jira Issue OCPBUGS-63573: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-63573 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What this PR does / why we need it
This PR addresses scheme compatibility issues in backup operations by:
v0.0.0-20250108163049-830af0531d12tov0.0.0-20251024225833-7a63e46b0d15(latest main)The main issue was that outdated hypershift API schemas were causing backup operations to fail when processing HyperShift resources. The updated dependency includes the latest schema definitions and fixes compatibility issues.
Additionally, this PR introduces automated dependency validation tests in
tests/integration/dependencies/that will alert when the hypershift/api dependency becomes too old (>30 days), preventing this issue from recurring.Which issue(s) this PR fixes
Fixes https://issues.redhat.com/browse/OCPBUGS-63573
Checklist
Testing
Additional Notes
The dependency validation test can be run independently:
go test ./tests/integration/dependencies -vThis test will fail if hypershift/api dependency is older than 30 days, providing early warning for scheme compatibility issues.