-
Notifications
You must be signed in to change notification settings - Fork 254
HIVE-2998: mockgen deprecated: use uber-go/mock instead #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sebrandon1: This pull request references HIVE-2998 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
596419f to
5dd11aa
Compare
5dd11aa to
e3aff7f
Compare
https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock. This PR changes the dependency to one that is maintained. Changes: - Updated Makefile to install uber-go/mock mockgen - Updated go.mod/go.sum to use go.uber.org/mock v0.6.0 - Updated all test files to import go.uber.org/mock/gomock - Updated all generated mock files - Fixed gomock.InOrder calls to use []any instead of []*gomock.Call - Re-vendored dependencies Tracking issue: redhat-best-practices-for-k8s/telco-bot#45
e3aff7f to
279c34a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2781 +/- ##
=======================================
Coverage 50.42% 50.42%
=======================================
Files 279 279
Lines 34198 34198
=======================================
Hits 17244 17244
Misses 15593 15593
Partials 1361 1361
🚀 New features to boost your workflow:
|
|
@sebrandon1: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://github.com/golang/mock is marked as archived as of
June 27, 2023. They recommend using go.uber.org/mock.This PR attempts to change the dependency to one that is maintained.
Tracking issue: redhat-best-practices-for-k8s/telco-bot#45