Skip to content

Conversation

@2uasimojo
Copy link
Member

This platform is no longer supported.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 10, 2025

@2uasimojo: This pull request references HIVE-2908 which is a valid jira issue.

Details

In response to this:

This platform is no longer supported.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jstuever and suhanime September 10, 2025 22:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@2uasimojo
Copy link
Member Author

/assign @dlom

...because I know red-dominant deltas are your favorite :)

Comment on lines +54 to +58
initialPoolVersion := "04a8f79a4a2e9733"
inventoryPoolVersion := "a6dcbd6776a3c92b"
inventoryAndCustomizationPoolVersion := "f1a16535dbc27559"
customizationPoolVersion := "564f99a732a771e9"
openstackPoolVersion := "0be50b7ba396d313"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ntr: These change any time the ClusterPool schema changes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2025
This platform is no longer supported.
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.54%. Comparing base (a4611b9) to head (fb278f8).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
contrib/pkg/createcluster/create.go 0.00% 1 Missing ⚠️
...g/controller/clusterpool/clusterpool_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2746      +/-   ##
==========================================
+ Coverage   50.15%   50.54%   +0.39%     
==========================================
  Files         288      284       -4     
  Lines       34130    33942     -188     
==========================================
+ Hits        17117    17156      +39     
+ Misses      15662    15444     -218     
+ Partials     1351     1342       -9     
Files with missing lines Coverage Δ
contrib/pkg/deprovision/deprovision.go 0.00% <ø> (ø)
pkg/constants/constants.go 100.00% <ø> (ø)
.../clusterdeployment/clusterdeployment_controller.go 65.42% <ø> (+0.26%) ⬆️
...g/controller/machinepool/machinepool_controller.go 63.40% <ø> (+0.14%) ⬆️
pkg/controller/utils/clusterdeployment.go 78.52% <ø> (+1.04%) ⬆️
pkg/install/generate.go 47.64% <ø> (+2.07%) ⬆️
pkg/installmanager/installmanager.go 35.66% <ø> (+0.39%) ⬆️
pkg/util/scheme/scheme.go 100.00% <ø> (ø)
.../v1/clusterdeployment_validating_admission_hook.go 87.03% <ø> (+1.14%) ⬆️
...s/hive/v1/machinepool_validating_admission_hook.go 85.21% <ø> (+1.94%) ⬆️
... and 5 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dlom
Copy link
Contributor

dlom commented Sep 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d9fbf25 into openshift:master Sep 11, 2025
20 checks passed
@2uasimojo 2uasimojo deleted the HIVE-2908/burn-ovirt branch September 11, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants