HIVE-1793: review followup

[2uasimojo]

No description provided.

[openshift-ci-robot]

@2uasimojo: This pull request references HIVE-1793 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[2uasimojo]

/assign @suhanime

[suhanime]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo,suhanime]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.93%. Comparing base (909ef5d) to head (56593f4).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2598   +/-   ##
=======================================
  Coverage   49.93%   49.93%           
=======================================
  Files         281      281           
  Lines       33136    33136           
=======================================
  Hits        16545    16545           
  Misses      15257    15257           
  Partials     1334     1334           

Files with missing lines	Coverage Δ
...g/controller/clusterpool/clusterpool_controller.go	58.04% <ø> (ø)
pkg/controller/utils/clusterdeployment.go	77.48% <ø> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.