Revendor installer: OpenStack >=1 MachineSet#2438
Conversation
We got unlucky when we revendored installer and picked up OCPBUGS-17064, which causes the MachineSets generator to produce zero MachineSets when the input specifies zero Replicas, as it does when we're autoscaling. Revendor to the (current) tip of the 4.14 branch to pick up the fix. HIVE-2590
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mce-2.4 #2438 +/- ##
========================================
Coverage 57.63% 57.63%
========================================
Files 186 186
Lines 25842 25843 +1
========================================
+ Hits 14893 14894 +1
Misses 9703 9703
Partials 1246 1246
|
|
/override ci/prow/security #2387 backport |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @dlom Local test on openstack checked out ✓ |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We got unlucky when we revendored installer and picked up OCPBUGS-17064, which causes the MachineSets generator to produce zero MachineSets when the input specifies zero Replicas, as it does when we're autoscaling.
Revendor to the (current) tip of the 4.14 branch to pick up the fix.
HIVE-2590
Manual redo of #2436