Skip to content

Revendor installer: OpenStack >=1 MachineSet#2438

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mce-2.4from
2uasimojo:HIVE-2590/revendor-openstack-min-1-mset
Sep 3, 2024
Merged

Revendor installer: OpenStack >=1 MachineSet#2438
openshift-merge-bot[bot] merged 1 commit intoopenshift:mce-2.4from
2uasimojo:HIVE-2590/revendor-openstack-min-1-mset

Conversation

@2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Sep 3, 2024

We got unlucky when we revendored installer and picked up OCPBUGS-17064, which causes the MachineSets generator to produce zero MachineSets when the input specifies zero Replicas, as it does when we're autoscaling.

Revendor to the (current) tip of the 4.14 branch to pick up the fix.

HIVE-2590

Manual redo of #2436

We got unlucky when we revendored installer and picked up OCPBUGS-17064,
which causes the MachineSets generator to produce zero MachineSets when
the input specifies zero Replicas, as it does when we're autoscaling.

Revendor to the (current) tip of the 4.14 branch to pick up the fix.

HIVE-2590
@openshift-ci openshift-ci bot requested review from jstuever and lleshchi September 3, 2024 15:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@codecov
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.63%. Comparing base (cdfcf06) to head (791fd3c).
Report is 2 commits behind head on mce-2.4.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.4    #2438   +/-   ##
========================================
  Coverage    57.63%   57.63%           
========================================
  Files          186      186           
  Lines        25842    25843    +1     
========================================
+ Hits         14893    14894    +1     
  Misses        9703     9703           
  Partials      1246     1246           
Files with missing lines Coverage Δ
pkg/controller/machinepool/awsactuator.go 78.43% <100.00%> (ø)
...g/controller/machinepool/machinepool_controller.go 53.78% <100.00%> (+0.05%) ⬆️

@2uasimojo
Copy link
Member Author

/override ci/prow/security

#2387 backport

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

Details

In response to this:

/override ci/prow/security

#2387 backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 791fd3c link true /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member Author

/assign @dlom

Local test on openstack checked out ✓

@dlom
Copy link
Contributor

dlom commented Sep 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aeb777c into openshift:mce-2.4 Sep 3, 2024
@2uasimojo 2uasimojo deleted the HIVE-2590/revendor-openstack-min-1-mset branch September 3, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants