machinepool: sort ownedLabels, ownedTaints#2386
Conversation
With these unsorted, it was possible to thrash MachinePools. HIVE-2541 (cherry picked from commit e243c43)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mce-2.5 #2386 +/- ##
========================================
Coverage 57.87% 57.88%
========================================
Files 187 187
Lines 26082 26088 +6
========================================
+ Hits 15095 15101 +6
Misses 9721 9721
Partials 1266 1266
|
|
/override "Red Hat Konflux / hive-mce-25-on-pull-request" |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux / hive-mce-25-on-pull-request DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @suhanime Manual backport, merge conflict on the test side. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, suhanime The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick mce-2.4 |
|
@2uasimojo: new pull request created: #2388 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
With these unsorted, it was possible to thrash MachinePools.
HIVE-2541
(cherry picked from commit e243c43)