Skip to content

machinepool: sort ownedLabels, ownedTaints#2386

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mce-2.5from
2uasimojo:HIVE-2541/sort-ownedLabels-ownedTaints-mce-2.5
Jul 31, 2024
Merged

machinepool: sort ownedLabels, ownedTaints#2386
openshift-merge-bot[bot] merged 1 commit intoopenshift:mce-2.5from
2uasimojo:HIVE-2541/sort-ownedLabels-ownedTaints-mce-2.5

Conversation

@2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Jul 31, 2024

With these unsorted, it was possible to thrash MachinePools.

HIVE-2541

(cherry picked from commit e243c43)

With these unsorted, it was possible to thrash MachinePools.

HIVE-2541

(cherry picked from commit e243c43)
@openshift-ci openshift-ci bot requested review from dlom and jstuever July 31, 2024 17:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (a76abfc) to head (68676c2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.5    #2386   +/-   ##
========================================
  Coverage    57.87%   57.88%           
========================================
  Files          187      187           
  Lines        26082    26088    +6     
========================================
+ Hits         15095    15101    +6     
  Misses        9721     9721           
  Partials      1266     1266           
Files Coverage Δ
...g/controller/machinepool/machinepool_controller.go 53.73% <100.00%> (+0.34%) ⬆️

@2uasimojo
Copy link
Member Author

/override ci/prow/security

Being addressed via #2353 and #2387

@2uasimojo
Copy link
Member Author

/override "Red Hat Konflux / hive-mce-25-on-pull-request"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux / hive-mce-25-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hive-mce-25-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

Details

In response to this:

/override ci/prow/security

Being addressed via #2353 and #2387

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
Copy link
Member Author

/assign @suhanime

Manual backport, merge conflict on the test side.

@suhanime
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 68676c2 link true /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 46627b9 into openshift:mce-2.5 Jul 31, 2024
@2uasimojo 2uasimojo deleted the HIVE-2541/sort-ownedLabels-ownedTaints-mce-2.5 branch July 31, 2024 20:03
@2uasimojo
Copy link
Member Author

/cherry-pick mce-2.4

@openshift-cherrypick-robot

@2uasimojo: new pull request created: #2388

Details

In response to this:

/cherry-pick mce-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants