AWS: Forbid case-insensitive credential_process#2366
AWS: Forbid case-insensitive credential_process#23662uasimojo merged 1 commit intoopenshift:masterfrom
credential_process#2366Conversation
A previous commit (openshift#2306 / 13ea4f4) put in checks to forbid the use of `credential_process` in AWS config/credentials files. It turns out that AWS accepts this key case-insensitively, so this commit updates our checks accordingly. HIVE-2485
openshift-ci
bot
added
the
approved
|
/assign @jstuever |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
=======================================
Coverage 58.54% 58.54%
=======================================
Files 181 181
Lines 25863 25863
=======================================
Hits 15141 15141
Misses 9447 9447
Partials 1275 1275
|
|
/test security Fix has merged for this 'un. Once e2e and e2e-pool pass the first time, I'm just going to force merge this. The things that have merged in the interim are orthogonal and we don't need to burn retests. |
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
A previous commit (#2306 / 13ea4f4) put in checks to forbid the use of
credential_processin AWS config/credentials files. It turns out that AWS accepts this key case-insensitively, so this commit updates our checks accordingly.HIVE-2485