Skip to content

MachinePools/OpenStack: Fix nil pointer exception #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 8, 2024
+12 −0
Merged

MachinePools/OpenStack: Fix nil pointer exception #2274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/controller/machinepool/openstackactuator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"k8s.io/apimachinery/pkg/types"
utilerrors "k8s.io/apimachinery/pkg/util/errors"
"k8s.io/apimachinery/pkg/util/json"
"k8s.io/utils/pointer"
"sigs.k8s.io/controller-runtime/pkg/client"

machinev1beta1 "github.com/openshift/api/machine/v1beta1"
Expand Down Expand Up @@ -66,6 +67,17 @@ func (a *OpenStackActuator) GenerateMachineSets(cd *hivev1.ClusterDeployment, po
}

computePool := baseMachinePool(pool)

// HIVE-2476: Avoid nil pointer exception in upstream MachineSets() call.
// In master, this was remedied by revendoring to pull in the upstream fix. See:
// https://github.com/openshift/installer/pull/8227
// https://github.com/openshift/hive/pull/2253
// In older branches this would have pulled in too many chained dependencies, so
// we're just fixing it "locally".
if computePool.Replicas == nil {
computePool.Replicas = pointer.Int64(0)
}

computePool.Platform.OpenStack = &installertypesosp.MachinePool{
FlavorName: pool.Spec.Platform.OpenStack.Flavor,
// The installer's MachinePool-to-MachineSet function will distribute the generated
Expand Down