Skip to content

DNM: UT for DNS preventing new Provision#2249

Closed
2uasimojo wants to merge 1 commit intoopenshift:masterfrom
2uasimojo:HIVE-2479/dns-should-prevent-provision
Closed

DNM: UT for DNS preventing new Provision#2249
2uasimojo wants to merge 1 commit intoopenshift:masterfrom
2uasimojo:HIVE-2479/dns-should-prevent-provision

Conversation

@2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Mar 26, 2024

@openshift-ci openshift-ci bot requested review from jstuever and lleshchi March 26, 2024 22:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.32%. Comparing base (fe0e302) to head (7c1db6f).
Report is 166 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2249   +/-   ##
=======================================
  Coverage   58.32%   58.32%           
=======================================
  Files         182      182           
  Lines       25704    25704           
=======================================
  Hits        14993    14993           
  Misses       9452     9452           
  Partials     1259     1259           

@2uasimojo
Copy link
Member Author

/test e2e-gcp

(Hijacking this PR to confirm e2e-gcp outage is not related to PR changes in #2251 and #2252.)

@2uasimojo
Copy link
Member Author

/test e2e-azure

(Might as well confirm the problem isn't affecting other e2es.)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@2uasimojo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 7c1db6f link true /test verify
ci/prow/e2e-gcp 7c1db6f link true /test e2e-gcp
ci/prow/e2e-azure 7c1db6f link true /test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 7, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Sep 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants