WIP: Fix OpenStack MachinePool unit tests

[2uasimojo]

The upstream installer MachineSet generator wants to make an actual API call to the OpenStack cloud to determine "trunk support" (whatever that may be). There's no good way to mock, fake, or work around this in unit tests. This commit proposes an upstream change to facilitate a workaround.

FOR COMMENT/REFERENCE ONLY. DO NOT MERGE.

Needed by HIVE-2476

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [2uasimojo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.45%. Comparing base (fba8d52) to head (8f55de5).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
+ Coverage   58.31%   58.45%   +0.13%     
==========================================
  Files         182      182              
  Lines       25692    25692              
==========================================
+ Hits        14982    15017      +35     
+ Misses       9451     9406      -45     
- Partials     1259     1269      +10     

see 1 file with indirect coverage changes

[openshift-ci]

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	8f55de5	link	true	/test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[2uasimojo]

openshift/installer#8187 is a cleaner solution for the upstream part. Will keep this open for the hive side, which still has useful bits. More complete plan:

• Wait for ⬆️
• Revendor installer
• Refactor hive mp controller to accommodate
• Fix this unit test
• Make this unit test moar bigger, including reproducing the problem in HIVE-2476
• Fix it
• Backport it

[2uasimojo]

Superseded by #2251