Skip to content

clusterpool_controller: Verify ClusterClaim Pending condition #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Aug 10, 2021
Merged

clusterpool_controller: Verify ClusterClaim Pending condition #1489

openshift-ci merged 1 commit into from
Aug 10, 2021

Conversation

@2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Aug 5, 2021

No description provided.

@openshift-ci openshift-ci bot requested review from dgoodwin and suhanime August 5, 2021 21:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@2uasimojo
Copy link
Member Author

2uasimojo commented Aug 5, 2021

/assign @abhinavdahiya
/cc @dgoodwin

@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #1489 (f5d877b) into master (3de9e02) will increase coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   41.23%   42.03%   +0.79%     
==========================================
  Files         334      334              
  Lines       30265    30653     +388     
==========================================
+ Hits        12481    12885     +404     
+ Misses      16722    16692      -30     
- Partials     1062     1076      +14
Impacted Files Coverage Δ
pkg/controller/utils/errorscrub.go 100.00% <0.00%> (ø)
.../clusterdeployment/clusterdeployment_controller.go 69.61% <0.00%> (+9.68%) ⬆️

@2uasimojo
Copy link
Member Author

2uasimojo commented Aug 5, 2021

/test e2e-pool

@2uasimojo 2uasimojo mentioned this pull request Aug 5, 2021
Merged
@2uasimojo 2uasimojo force-pushed the pool-controller-claim-conditions branch from 5f7a5f6 to f5d877b Compare August 5, 2021 22:56
@2uasimojo
Copy link
Member Author

2uasimojo commented Aug 6, 2021

/cc @suhanime

@2uasimojo 2uasimojo mentioned this pull request Aug 6, 2021
Merged
suhanime
suhanime reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@suhanime suhanime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2uasimojo
Copy link
Member Author

2uasimojo commented Aug 9, 2021

/test e2e

@openshift-bot
Copy link

openshift-bot commented Aug 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@2uasimojo
Copy link
Member Author

2uasimojo commented Aug 9, 2021

/test e2e-pool

@openshift-bot
Copy link

openshift-bot commented Aug 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Aug 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit c8a5714 into openshift:master Aug 10, 2021
@2uasimojo 2uasimojo deleted the pool-controller-claim-conditions branch August 11, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suhanime suhanime suhanime left review comments

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

Assignees

@abhinavdahiya abhinavdahiya

@suhanime suhanime

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@2uasimojo @openshift-bot @suhanime @abhinavdahiya