Introduce e2e-pool test #1482
Introduce e2e-pool test #1482
Conversation
openshift-ci
bot
added
the
approved
|
/test e2e-pool |
|
/hold Not quite done with this yet. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-pool |
|
/test e2e-pool |
|
/test e2e-pool |
| @@ -0,0 +1,181 @@ | |||
| max_tries=60 | |||
There was a problem hiding this comment.
Note to reviewers: There's quite a bit of cleanup/refactoring that could be done here, but I explicitly didn't do that so it'd be easier to review: use your favorite visual diff tool to compare this file to the original e2e-test.sh.
There was a problem hiding this comment.
do you mind moving this move to separate commit. that would be a lot more read able.
There was a problem hiding this comment.
I'm not sure how much more readable it would make anything. That commit would simply comprise e2e-common.sh and e2e-test.sh in the exact form they exist in this PR.
There was a problem hiding this comment.
Possible misunderstanding here, refactoring that could be done, but isn't in this PR.
There was a problem hiding this comment.
Correct: I kept the existing code from e2e-test.sh, warts and all, and just moved it to e2e-common.sh with as little change as possible, precisely to make this PR more scrutable. We can refactor/reorganize later.
|
/test e2e-pool |
|
/hold cancel Working. Ready for review. Here's a full log of a successful run. (Note the middle bit is pretty huge because we grab full CD json ~30x. We can turn off |
openshift-ci
bot
removed
the
do-not-merge/hold
| fi | ||
|
|
||
| i=$((i + 1)) | ||
| done |
There was a problem hiding this comment.
should we not need to verify that the namespace creation was successfull when we exit this loop (so we can have a clearer error message in the even that this never succeeded)?
There was a problem hiding this comment.
Absolutely. There's a couple of things here, including the fact that the command to restore the original namespace doesn't work at all for me. I'd like to defer that to a separate PR if possible, to keep this file as cleanly cut/paste as possible.
This test - Stands up a clusterpool of size=1 - Waits for its ClusterDeployment to be Installed and Hibernating - Creates a claim and waits for the CD to be Running - Hibernates the CD and waits for it to be Hibernating - Resumes the CD and waits for it to be Running - Deletes the claim and the pool - Waits for all CDs to disappear HIVE-1605
|
/test e2e-pool |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dgoodwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
The e2e-pool test now exists and is functional (openshift/hive#1482). Make it run mandatorily for all PRs except those that only touch docs (same configuration as other required jobs). HIVE-1605
5 participants
HIVE-1605