update gomock

[joelddiaz]

PRs failing like so https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_hive/120/pull-ci-openshift-hive-master-unit/208

failed to wait for test pod to complete: could not wait for pod completion: the pod ci-op-kn2253g0/unit failed after 1m35s (failed containers: test):  unknown

Container test exited with code 2, reason Error
---
go generate ./pkg/... ./cmd/...
gofmt -w -s pkg contrib
go vet ./pkg/... ./cmd/... ./contrib/...
# github.com/openshift/hive/pkg/awsclient/mock
pkg/awsclient/mock/client_generated.go:43:8: m.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:52:14: mr.mock.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:58:8: m.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:67:14: mr.mock.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:73:8: m.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:82:14: mr.mock.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:88:8: m.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:97:14: mr.mock.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:103:8: m.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:112:14: mr.mock.ctrl.T undefined (type *gomock.Controller has no field or method T, but does have gomock.t)
pkg/awsclient/mock/client_generated.go:112:14: too many errors
make: *** [vet] Error 2

Update gomock/mockgen

[dgoodwin]

One tiny nit, otherwise looks good, I was going to point out you can just update specific deps but it sounds like you did, so dep bites us again. Thanks for taking on and solving this.

[dgoodwin]

You can remove this.

[joelddiaz]

fixed

[dgoodwin]

/lgtm

[wking]

The "admin password" reference is stale now. I'm not sure what to replace it with though, because I don't understand the whole "caller will lookup" idea. The caller is passing these into GenerateInstallConfig, so why would they need to look them up at all? And how do secrets come into this?

[dgoodwin]

In hive's ClusterDeployment the sshKey and pullSecret (and previously admin password) are referenced via secrets. Whatever code calls this needs to look them up, I didn't want this function responsible for talking to etcd.