Skip to content

awstagdeprovision: Ignore more errors #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Nov 27, 2018
Merged

awstagdeprovision: Ignore more errors #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contrib/pkg/awstagdeprovision/awstagdeprovision.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,8 @@ func deleteS3Buckets(session *session.Session, filter AWSFilter, clusterName str

awsObjects, err := bucketsToAWSObjects(results.Buckets, s3Client, logger)
if err != nil {
return false, fmt.Errorf("error converting buckets to internal objects: %v", err)
logger.Debugf("error converting s3 buckets to native AWS objects: %v", err)
return false, nil
}

filteredObjects := filterObjects(awsObjects, filter)
Expand Down Expand Up @@ -1381,7 +1382,7 @@ func deleteRoute53(session *session.Session, filters AWSFilter, clusterName stri
awsZones, err := r53ZonesToAWSObjects(allZones.HostedZones, r53Client)
if err != nil {
logger.Debugf("error converting r53Zones to native AWS objects: %v", err)
return false, fmt.Errorf("error converting route53 zones to internal AWS objects: %v", err)
return false, nil
}

filteredZones := filterObjects(awsZones, filters)
Expand Down