Skip to content

OCPBUGS-59749: 4.19: UPSTREAM: 2116: Remove check on snapshot create support for multi-writer HyperDisk-HA and let such validations occur at the PD control plane layer #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 5, 2025
Merged

OCPBUGS-59749: 4.19: UPSTREAM: 2116: Remove check on snapshot create support for multi-writer HyperDisk-HA and let such validations occur at the PD control plane layer #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/gce-pd-csi-driver/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,9 +1588,6 @@ func (gceCS *GCEControllerServer) CreateSnapshot(ctx context.Context, req *csi.C
}
return nil, common.LoggedError("CreateSnapshot, failed to getDisk: ", err)
}
if common.IsHyperdisk(disk.GetPDType()) && disk.GetAccessMode() == common.GCEReadWriteManyAccessMode {
return nil, status.Errorf(codes.InvalidArgument, "Cannot create snapshot for disk type %s with access mode %s", common.DiskTypeHdHA, common.GCEReadWriteManyAccessMode)
}

snapshotParams, err := common.ExtractAndDefaultSnapshotParameters(req.GetParameters(), gceCS.Driver.name, gceCS.Driver.extraTags)
if err != nil {
Expand Down
18 changes: 0 additions & 18 deletions pkg/gce-pd-csi-driver/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,24 +265,6 @@ func TestCreateSnapshotArguments(t *testing.T) {
ReadyToUse: false,
},
},
{
name: "fail to create snapshot for HdHA multi-writer",
req: &csi.CreateSnapshotRequest{
Name: name,
SourceVolumeId: testRegionalID,
Parameters: map[string]string{common.ParameterKeyStorageLocations: " US-WEST2"},
},
seedDisks: []*gce.CloudDisk{
gce.CloudDiskFromV1(&compute.Disk{
Name: name,
SelfLink: fmt.Sprintf("https://www.googleapis.com/compute/v1/projects/project/regions/country-region/name/%s", name),
Type: common.DiskTypeHdHA,
AccessMode: common.GCEReadWriteManyAccessMode,
Region: "country-region",
}),
},
expErrCode: codes.InvalidArgument,
},
}

for _, tc := range testCases {
Expand Down