CFE-877: Add resourceTags in Infrastructure to driver args list#92
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@bharath-b-rh: This pull request references CFE-877 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/test operator-e2e |
|
/label qe-approved |
openshift-ci
Bot
added
the
qe-approved
|
@bharath-b-rh: This pull request references CFE-877 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/remove-hold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@gnufied ^^ |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/label px-approved |
openshift-ci
Bot
added
px-approved
|
/test operator-e2e |
|
/test ci-index-gcp-filestore-csi-driver-operator-bundle |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test operator-e2e |
|
/retest-required |
| # If set to true, don't check whether the requested | ||
| # roles have the necessary services enabled | ||
| skipServiceCheck: false | ||
| skipServiceCheck: true |
There was a problem hiding this comment.
skipServiceCheck is enabled, since roles/resourcemanager.tagUser requires certain services to be enabled, which are not necessarily required for creating OpenShift cluster required resources.
time="2024-08-08T08:06:07Z" level=warning msg="Detected required APIs that are disabled: [alloydb.googleapis.com clouddeploy.googleapis.com cloudsql.googleapis.com datafusion.googleapis.com datastream.googleapis.com domains.googleapis.com managedidentities.googleapis.com]" actuator=gcp cr=openshift-cloud-credential-operator/openshift-gcp-filestore-csi-driver-operator
time="2024-08-08T08:06:07Z" level=error msg="not all required service APIs are enabled" actuator=gcp cr=openshift-cloud-credential-operator/openshift-gcp-filestore-csi-driver-operator
time="2024-08-08T08:06:07Z" level=error msg="error syncing credentials: not all required service APIs are enabled" controller=credreq cr=openshift-cloud-credential-operator/openshift-gcp-filestore-csi-driver-operator secret=openshift-cluster-csi-drivers/gcp-filestore-cloud-credentials
time="2024-08-08T08:06:07Z" level=error msg="errored with condition: CredentialsProvisionFailure" controller=credreq cr=openshift-cloud-credential-operator/openshift-gcp-filestore-csi-driver-operator secret=openshift-cluster-csi-drivers/gcp-filestore-cloud-credentials
|
/lgtm |
|
/test security |
|
don't bother with security, it's not a mandatory one |
|
@bharath-b-rh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-gcp-filestore-csi-driver-operator |
6 participants
PR has the changes for openshift/enhancements#1217 proposed to support GCP tags in OCP, which requires gcp-filestore-csi-driver-operator to add gcp resourceTags available in the status sub-resource of infrastructure CR, to the gcp resources created by the driver.