Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test that require machine configs on ROSA HCP #554

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Aug 9, 2024

We recently added support for running tests on ROSA HCP, which doesn't
support some objects like Machine Configs:

openshift/release#53502

Because of this, the TestFileIntegrityAcceptsExpectedChange test is
failing because it expects to create a Machine Config as a dependency
for the test.

This commit updates the test to check if we're running on ROSA HCP, and
if so, skip the test.

We recently added support for running tests on ROSA HCP, which doesn't
support some objects like Machine Configs:

  openshift/release#53502

Because of this, the TestFileIntegrityAcceptsExpectedChange test is
failing because it expects to create a Machine Config as a dependency
for the test.

This commit updates the test to check if we're running on ROSA HCP, and
if so, skip the test.
@rhmdnd rhmdnd requested a review from Vincent056 August 9, 2024 12:49
@openshift-ci openshift-ci bot requested a review from BhargaviGudi August 9, 2024 12:51
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 18, 2024

/test e2e-rosa

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 8b3bcf7 link true /test e2e-aws
ci/prow/e2e-rosa 8b3bcf7 link false /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants