-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip test that require machine configs on ROSA HCP #554
base: master
Are you sure you want to change the base?
Conversation
We recently added support for running tests on ROSA HCP, which doesn't support some objects like Machine Configs: openshift/release#53502 Because of this, the TestFileIntegrityAcceptsExpectedChange test is failing because it expects to create a Machine Config as a dependency for the test. This commit updates the test to check if we're running on ROSA HCP, and if so, skip the test.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-rosa |
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
We recently added support for running tests on ROSA HCP, which doesn't
support some objects like Machine Configs:
openshift/release#53502
Because of this, the TestFileIntegrityAcceptsExpectedChange test is
failing because it expects to create a Machine Config as a dependency
for the test.
This commit updates the test to check if we're running on ROSA HCP, and
if so, skip the test.