Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operator and aide-ds pod limits #176

Merged
merged 1 commit into from
May 24, 2021
Merged

Add operator and aide-ds pod limits #176

merged 1 commit into from
May 24, 2021

Conversation

mrogers950
Copy link
Contributor

@mrogers950 mrogers950 commented May 18, 2021 •
edited by JAORMX
Loading

Closes #68

@openshift-ci openshift-ci bot requested review from JAORMX and jhrozek May 18, 2021 23:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@mrogers950
Copy link
Contributor Author

/test all

JAORMX
JAORMX suggested changes May 20, 2021
View reviewed changes
pkg/controller/fileintegrity/fileintegrity_controller.go Outdated Show resolved Hide resolved
deploy/operator.yaml Outdated Show resolved Hide resolved
JAORMX
JAORMX approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JAORMX, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mrogers950
Copy link
Contributor Author

The compressed log scan took quite a bit longer it seems
/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@JAORMX
Copy link
Contributor

JAORMX commented May 21, 2021

If it takes too much of an impact we should increase the limit again then :/

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@JAORMX
Copy link
Contributor

JAORMX commented May 24, 2021

/test all

@JAORMX JAORMX merged commit 7404143 into openshift:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

@jhrozek jhrozek Awaiting requested review from jhrozek

Assignees

@JAORMX JAORMX

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set resource limits for containers
3 participants
@mrogers950 @openshift-bot @JAORMX