CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster#915
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 6, 2021
Merged
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
vojtechszocs
suggested changes
Oct 1, 2021
vojtechszocs
reviewed
Oct 1, 2021
spadgett
reviewed
Oct 1, 2021
Member
|
cc @jamestalton |
spadgett
reviewed
Oct 6, 2021
| After that plugin can make request to the console endpoint, which will | ||
| proxy the request to the dependent service. Plugin's request shall use | ||
| following console's endpoint: | ||
| `/api/plugin-proxy/<dependent-service-name>/<request-path>` |
Member
There was a problem hiding this comment.
This path isn't guaranteed to be unique. We should include the service namespace and port in the path.
Member
There was a problem hiding this comment.
Maybe
Suggested change
| `/api/plugin-proxy/<dependent-service-name>/<request-path>` | |
| `/api/proxy/namespace/<service-namespace>/service/<service-name>:<port-number>/<request-path>?<optional-query-parameters>` |
I'd suggest providing a concrete example URL and what service URL that it maps to.
Contributor
There was a problem hiding this comment.
Another option is to use e.g. /api/proxy/<plugin-name>/<service-name>/<request-path> since there can be only one proxy service with the given name for the given ConsolePlugin resource manifest.
Member
There was a problem hiding this comment.
Service name is not unique... A plugin can proxy to two services with the same name in different namespaces, or the same service, but different ports.
jhadvig
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
@spadgett @vojtechszocs PTAL |
vojtechszocs
suggested changes
Oct 6, 2021
spadgett
reviewed
Oct 6, 2021
Member
Author
|
Thanks for additional comments! I've addressed them 👍 |
vojtechszocs
reviewed
Oct 6, 2021
spadgett
reviewed
Oct 6, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of the proposed feature for allowing dynamic plugins to proxy to services on the cluster.
Story: https://issues.redhat.com/browse/CONSOLE-2892
/assign @spadgett @vojtechszocs @christianvogt