Skip to content

Conversation

@s-urbaniak
Copy link
Contributor

No description provided.

This was referenced Oct 1, 2021
@s-urbaniak s-urbaniak force-pushed the podsecurity branch 2 times, most recently from 2823a2e to b9716dd Compare October 4, 2021 11:52
@mfojtik
Copy link
Contributor

mfojtik commented Oct 4, 2021

/approve

this is in line with the plan that was debated in control plane theme call and also internally.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
Comment on lines 60 to 68
1. (DONE) Enable the PodSecurity admission plugin in no-op mode but with the ability to audit policy violations.

- https://github.com/openshift/api/pull/1001 add `PodSecurity` to default enabled feature set in OpenShift hyperkube
- https://github.com/openshift/cluster-kube-apiserver-operator/pull/1217 enable `PodSecurity` admission plugin and provide a default configuration
- https://github.com/openshift/kubernetes/pull/950 vendor api changes in openshift/kubernetes
- https://github.com/openshift/cluster-kube-apiserver-operator/pull/1231 enable `PodSecurity` feature gate in kube-apiserver-operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't post PRs in an enhancement and would stick with just the plan. You can xref the PRs in the comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no disagreement, let's remove them then, at the same time leaving them here as a comment:

@s-urbaniak s-urbaniak force-pushed the podsecurity branch 2 times, most recently from b99704d to da300a4 Compare October 5, 2021 10:23
@s-urbaniak
Copy link
Contributor Author

/retest

@stlaz
Copy link
Contributor

stlaz commented Oct 5, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 161604c into openshift:master Oct 5, 2021
@s-urbaniak s-urbaniak deleted the podsecurity branch October 5, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants