Skip to content

Add ICSP with repositoryMirrors to v1 #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 24, 2021
Merged

Add ICSP with repositoryMirrors to v1 #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions enhancements/api-review/add-repositoryMirrors-spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ reviewers:
approvers:
- TBD
creation-date: 2021-03-10
last-updated: 2021-03-10
last-updated: 2021-08-19
status: implementable
---

Expand Down Expand Up @@ -73,7 +73,7 @@ It will now watch for mirrors configured through spec `repositoryMirrors` to not

An example ImageContentSourcePolicy file will look like:
```yaml
apiVersion: operator.openshift.io/v1alpha1
apiVersion: operator.openshift.io/v1
kind: ImageContentSourcePolicy
metadata:
name: ubi8repo
Expand Down Expand Up @@ -102,7 +102,7 @@ Implementing this enhancement requires changes in:
This is an example of the ImageContentSourcePolicy file:

```yaml
apiVersion: operator.openshift.io/v1alpha1
apiVersion: operator.openshift.io/v1
kind: ImageContentSourcePolicy
metadata:
name: ubi8repo
Expand Down Expand Up @@ -164,8 +164,13 @@ determine graduation.

#### Removing a deprecated feature

- With `repositoryMirrors` getting in, the current `repositoryDigestMirrors` can be deprecated since its functionality will also be fully satisfied by `repositoryMirrors` and we don't have to keep duplicated APIs.
- In operator.openshift.io/v1alpha1, gently announce to the users the `repositoryDigestMirrors` will be deprecated. In operator.openshift.io/v1alpha2, the implementation of `repositoryDigestMirrors` will be removed and replaced by `repositoryMirrors`.
- The `ImageContentSourcePolicy` CRD with `repositoryMirrors` will be added to operator.openshift.io/v1. With `repositoryMirrors` getting in, the`repositoryDigestMirrors` will be
removed and replaced by `repositoryMirrors`, since its functionality can be fully satisfied by
`repositoryMirrors` and we don't have to keep duplicated APIs.
- In operator.openshift.io/v1alpha1, the `ImageContentSourcePolicy` will be kept it as it is.
- The MCO will support both versions of `ImageContentSourcePolicy`. The support will need to
be add to MCO for accepting request of v1 and v1alpha1, and handles the requests depending on
different versions.

### Upgrade / Downgrade Strategy

Expand Down