[WIP] Add platforms/aws/customer-provisioned-vpc-and-subnets #67
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/L
This enhancement extends `openshift-installer` to support installation intexisting AWS VPCs and Subnets.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
sdodson
force-pushed
the
aws-vpc-subnets
branch
from
6547054 to
3ef778b
Compare
|
/cc @wking |
openshift-ci-robot
requested review from
wking
and removed request for
ironcladlou and
shawn-hurley
| subnets or the VPC options like DHCP etc.). Therefore the installer can only | ||
| validate the assumptions about the networking setup. The installer may assume | ||
| that use has NAT gateways, internet gateways, etc. setup, and installation may | ||
| fail if these assumptions are violated. Or the installer may attempt to |
There was a problem hiding this comment.
I think we can get rid of "Or the installer.." here?
There was a problem hiding this comment.
we're planning to do at least some network validation.
|
|
||
| ## Alternatives | ||
|
|
||
| TODO, some can be ported from this private document https://docs.google.com/document/d/1eNtnrsMUL2efRC5Y8w6CL4f_GxTHrIij8cnyQQnUhW8/edit#heading=h.ttvcmxr8sl3b |
There was a problem hiding this comment.
@wking can i get your thoughts on which alternatives items we want to port over from the design document? Most seemed related to CI rather than the implementation itself.
| installer cannot modify the networking setup (i.e. the route tables for the | ||
| subnets or the VPC options like DHCP etc.). Therefore the installer can only | ||
| validate the assumptions about the networking setup. The installer may assume | ||
| that use has NAT gateways, internet gateways, etc. setup, and installation may |
|
Do we need an enhancement for this? As far as I can tell, it's completely installer-side with no cross-team coordination required. I'd been trying to land motivation and considered alternatived in the individual implementation pivots (so far openshift/installer#2438, openshift/installer#2467, and openshift/installer#2477). If we want a detailed design discussion in a public place, the open installer issue openshift/installer#1083 might be more appropriate. |
| Destroy will remain mostly unchanged, hinging on the kubernetes.io/cluster/.\*: owned tag. We will need to grow new code to store kubernetes.io/cluster/.\*: shared in metadata.json and remove it from resources on which it is found. | ||
|
|
||
| We should probably revert: | ||
| - #1268, which began removing instance profiles by name. That was a workaround to recover from openshift-dev clusters which were partially-deleted by the DPP reaper. Folks using the installer’s destroy code won’t need it, and while the risk of accidental name collision is low, I don’t think it’s worth taking that risk. |
There was a problem hiding this comment.
based on the conversation in openshift/installer#2461 seems like we are not going to revert 1268 for now.
|
/close |
|
@sdodson: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This enhancement extends
openshift-installerto support installationintexisting AWS VPCs and Subnets.
TODO: