Initial proposal of allow mtu and overlay port changes #603
Conversation
openshift-ci-robot
requested review from
abhat,
danwinship,
knobunc,
mccv1r0 and
trozet
|
|
||
| `ovs-vsctl --if-exists del-port br0 vxlan0` | ||
|
|
||
| And create it again with no delay at all: |
There was a problem hiding this comment.
Is this procedure actually already tested or is this just a guess/placeholder? If the latter, you don't need to specify it in that much detail here.
There was a problem hiding this comment.
I tested this manually. Should I make it less detailed anyway?
There was a problem hiding this comment.
@juanluisvaladas I'd like to leave detailed steps where possible. Could be helpful for QE to understand the flow of the things. Right now it seems useful to understand what's being planned.
juanluisvaladas
force-pushed
the
change-mtu-port
branch
2 times, most recently
from
7080c3f to
209a65e
Compare
|
Just fixed a problem with markdownlint, the actual content doesn't change at all. |
- Detail when will the tests will be run - Do the preconditions in a separate daemonset. - Make all the API calls in CNO instead of doing them in the pods ran on each node.
juanluisvaladas
force-pushed
the
change-mtu-port
branch
from
0aabef8 to
b746514
Compare
|
I'm good with the direction of this. I'll leave it to someone from the SDN team to lgtm the details of the plan. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: russellb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
kedark3
left a comment
kedark3
left a comment
There was a problem hiding this comment.
Hi @juanluisvaladas thanks for providing detailed info on enhancements. Some minor spelling nitpicks. Hope you don't mind. Thanks.
| approvers: | ||
| - TBD | ||
| creation-date: 2021-01-25 | ||
| last-updated: 2022-02-012 |
|
|
||
| Customers may need to change the MTU, or the ports used for VXLAN or Geneve | ||
| tunnels post-installation. However these changes aren't trivial and may cause | ||
| downtime, hence the CNO forbids currently them. |
There was a problem hiding this comment.
Request: s/the CNO forbids currently them/forbids them currently/
| * Allow to change the overlay network ports on the underlay in both OpenShift | ||
| SDN and OVN Kubernetes. | ||
|
|
||
| * Allow to change both VXLAN and Geneve ports porst install. |
There was a problem hiding this comment.
Request: s/ ports porst install./ ports post install./
| 1. Set the `clusteroperator/network` conditions: | ||
| - Progressing: true | ||
| - Upgradeable: false | ||
| 2. Deploy a deaemonset with `restartPolicy: Mever` which is responsible for |
There was a problem hiding this comment.
Request: s/restartPolicy: Mever/restartPolicy: Never
|
|
||
| Once the preconditions are met the steps to change the MTU and the ports are | ||
| different, for MTU changes the CNO will: | ||
| 1. Cordon every node, we don't want pods created during the process. |
There was a problem hiding this comment.
Sorry for naive question, is it a rolling cordon or all at once ?
| 1. Cordon every node, we don't want pods created during the process. | ||
| 2. Deploy a new daemonset that will run on every node which will apply the | ||
| changes that must be done manually in that node in particular. | ||
| 3. So that we don't have nodes doing things a t different times and we have |
There was a problem hiding this comment.
s/things a t different/things at different/
| 1. Cordon every node, we don't want pods created during the process. | ||
| 2. Deploy a new daemonset that will run on every node which will apply the | ||
| changes that must be done manually in that node in particular. | ||
| 3. So that we don't have nodes doing things a t different times and we have |
There was a problem hiding this comment.
s/things a t different/things at different/
|
|
||
| `ovs-vsctl --if-exists del-port br0 vxlan0` | ||
|
|
||
| And create it again with no delay at all: |
There was a problem hiding this comment.
@juanluisvaladas I'd like to leave detailed steps where possible. Could be helpful for QE to understand the flow of the things. Right now it seems useful to understand what's being planned.
| kept alive, and the short lived connections get established. | ||
|
|
||
| Packet loss, TCP retransmissions, increased latency, and reduced bandwidth are | ||
| considered acceptable while the chane is happening. |
|
Maybe a good idea to close this as a new one #730 is now opened. |
can you clarify why a new enhancement was opened instead of updating this one? |
|
original author of this enhancement is no longer working on this /close |
|
@russellb: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
For SDN-1365. Proposes changes to CNO to make it possible for customers to change the MTU, geneve port, and vxlan port in both OVN Kubernetes, and openshift SDN.
/cc @mccv1r0
For MTU changes
/cc @trozet
For OVN kubernetes
/cc @danwinship @knobunc @abhat
For general thoughts