WIP: Add FCCT support in MC proposal

[LorbusChris]

Rendered

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LorbusChris
To complete the pull request process, please assign hardys after the PR has been reviewed.
You can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[LorbusChris]

/cc @crawford @ashcrow @cgwalters @runcom

[LorbusChris]

Note to myself:

• Add explanation that only a subset of Ignition (and thus FCC) features is supported by MCO
• Add mention of FCC variants (current implementation in PR *: Support CoreOS configs in MCs machine-config-operator#1980 does not use a variant parser, but the variant-agnostic base parser). Currently only a fcos variant exists, but a rhcos variant is planned.

[cgwalters]

I think this is conditional on coreos/butane#79 - maintaining that split is probably the bulk of the effort here, including dealing with the set of things in FCOS but not RHCOS (switching streams, zincati, etc. - there may be more in the future but hopefully we keep it constrained)

[cgwalters]

I've been thinking about this more. It feels like we should do a more clean break here and introduce a new coreosconfig CRD that is just this. The way MachineConfig is either Ignition or the "custom MC stuff" (or both) is confusing. Plus it has things users shouldn't set like osImageURL.

(Internally coreosconfigs would compile into machineconfig of course)

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[LorbusChris]

I've been thinking about this more. It feels like we should do a more clean break here and introduce a new coreosconfig CRD that is just this. The way MachineConfig is either Ignition or the "custom MC stuff" (or both) is confusing. Plus it has things users shouldn't set like osImageURL.

(Internally coreosconfigs would compile into machineconfig of course)

I'm closing this proposal in favor of the approach described above
/close

[openshift-ci-robot]

@LorbusChris: Closed this PR.

Details

In response to this:

I've been thinking about this more. It feels like we should do a more clean break here and introduce a new coreosconfig CRD that is just this. The way MachineConfig is either Ignition or the "custom MC stuff" (or both) is confusing. Plus it has things users shouldn't set like osImageURL.

(Internally coreosconfigs would compile into machineconfig of course)

I'm closing this proposal in favor of the approach described above
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.