register the metrics port for the baremetal-operator - #470
Merged
openshift-merge-robot merged 1 commit intoSep 11, 2020
Conversation
openshift-ci-robot
added
the
approved
Contributor
Author
russellb
suggested changes
Sep 11, 2020
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
dhellmann
force-pushed
the
bmo-metrics-port
branch
from
September 11, 2020 18:59
1655902 to
df5793d
Compare
Contributor
Author
|
The update as been squashed and this should be ready to merge. |
russellb
approved these changes
Sep 11, 2020
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mkowalski
added a commit
to mkowalski/openshift-enhancements
that referenced
this pull request
Aug 6, 2026
Incorporate the remaining implementation findings and address fedepaol's review (4853101609): - MetalLB: coexistence added as a goal, folded into the CR-ownership and garbage-collection contract, and backed by live validation (three FRRConfiguration producers on one cluster; day-2 MetalLB operator in frr-k8s-external mode merging into the same neighbor the VIP CR declares). - rawConfig: explicitly framed as an interim carrier (the frr-k8s API declares it unsupported); committed migration to the first-class redistribution API (metallb/frr-k8s#469 + design PR openshift#470). - Bootstrap/steady-state: steady state clarified as the same handover configuration; node-reboot sequencing documented; file-form FRRConfiguration source named as the pre-GA direction (one config language end to end, replacing the frr.conf handover seam). - OVN-K section rewritten: no awareness of the VIP configuration needed; the contract is additive CR ownership plus GC scoped to own CRs (applies to MetalLB symmetrically). - ip import-table dropped everywhere (implementation finding: table-direct reads the kernel table directly; import-table was unnecessary and copies routes into the main table). - kube-vip-ingress scope corrected: rendered for all nodes via MCO templates/common (keepalived parity), workers advertise via the CNO DaemonSet instance. - FRRConfiguration is a single cluster-wide bgp-vip CR (no node selector); OVN-K CR naming corrected to ovnk-generated-*. - Second zebra bug documented (FRRouting/frr#22654, fixed upstream via #22676) with the kube-vip re-assertion as optional hardening; FRR version/backport requirements consolidated. - kube-vip restart-on-settled-cluster gap added to Risks (kubeconfig points at a node IP the serving cert does not cover). - Test Plan updated with the implemented CI lanes (e2e-metal-ipi-bgp-vip and the three coexistence lanes); Implementation Experience refreshed (27 installs, merged upstream work). Assisted-By: Claude Fable 5 Signed-off-by: Mat Kowalski <mko@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the port number the MAO uses when configuring the baremetal-operator in 4.6.
The pod uses host networking, and only runs on the control plane. Maybe that means this value needs to be part of a different list?