-
Notifications
You must be signed in to change notification settings - Fork 533
Bootstrap an OpenShift conventions document for the project #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONVENTIONS.md
Outdated
| ## Motivation | ||
|
|
||
| The conventions are intended to help with consistency across the project. Users | ||
| of the platform expect this consistency in the experience and operation of the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developers of the platform expect this consistency in the code to quickly identify issues across codebases.
Maybe a comment too about how consistency simplifies explanation, reduces accidental complexity.
|
cc @derekwaynecarr @markmc @crawford @eparis @russellb since your names are on it as authors / approvers / reviewers |
|
we can add this as a follow-on PR, but I want to capture outcomes for some discussions. When should an operand tolerate all taints?
An operand that tolerates all taints must implicitly tolerate in their component:
/cc @Miciah - i think this covers what we discussed. |
|
@derekwaynecarr yeah lets do that in a follow-on, it will need a new section |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwforres, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.