-
Notifications
You must be signed in to change notification settings - Fork 535
enhancements/etcd/disaster-recovery-with-ceo: add backup proposal #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hexfusion The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
| 4. On all masters copy directory `/etc/kubernetes/static-pod-manifests/kube-apiserver-pod-${APISERVER_REVISION}` | ||
| to `/etc/kubernetes/static-pod-manifests/backup-N/kube-apiserver-pod`. | ||
| 5. On all masters replace directory `/etc/kubernetes/static-pod-manifests/backups` with a copy of | ||
| `/etc/kubernetes/static-pod-manifests/backup-N` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On 5, would a symoblic link of /etc/kubernetes/static-pod-manifests/backups to /etc/kubernetes/static-pod-manifests/backup-N be better, perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, the size of the etcd snapshot would not make a copy reasonable. Managing the link would be simpler.
|
|
||
| 1. On all masters create a new backup revision `/etc/kubernetes/static-pod-manifests/backup-N`. | ||
| 2. On all masters write `/etc/kubernetes/static-pod-manifests/backup-N/backup.env` file containing 3 environmental | ||
| variables `CREATED`, `ETCD_REVISION` and `APISERVER_REVISION`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be extended now as we are managing more static pods resources. I think we should also include OCP version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backups might eventually be managed by a static pod controller. This proposal sets up a directory structure to make that easier to implement.
The idea here is that each master is prepared for restoring the cluster in possible autonomous fashion.
cc @deads2k @alaypatel07 @retroflexer