CNF-13731: Cert Manager HTTP01 Proxy - #1773
Conversation
|
@sebrandon1: This pull request references CNF-13731 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @sebrandon1. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sebrandon1: This pull request references CNF-13731 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
faf4430 to
b77ce7e
Compare
|
It looks like the I'm not sure what the policy is on removing certain sections all together, but at the very least I would expect to still see the following sections:
If you need a more explicit template to follow for this EP, there is one with some good general advice for what should be in each section here: https://github.com/openshift/enhancements/blob/master/guidelines/enhancement_template.md |
|
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
ae29d68 to
21b454b
Compare
|
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@sebrandon1: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sebrandon1: This pull request references CNF-13731 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bc39b89 to
ab590b5
Compare
0975367 to
67d3e63
Compare
everettraven
left a comment
There was a problem hiding this comment.
Circling back around to this to read the latest updates and overall this looks like it is moving in the right direction.
Some things that are still needed IMO:
- Explicit decision on what is going to deploy and manage the resources associated with this proxy
- Call out in the implementation section the new feature gate that will be added for this feature
|
@everettraven For other features that have this boolean style on/off type of feature implementation, what do they do as far as the toggle and where/how does that get implemented? Are there any other such features that you would recommend following that are similar? I think if we could stick closer to another implementation it would be better than re-inventing the wheel for a similar feature? What do you think? |
|
/remove-lifecycle rotten |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle rotten |
|
/remove-lifecycle stale |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
|
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
|
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add enhancement for HTTP01 Challenge Proxy as a controller within cert-manager-operator, following the istio-csr-controller pattern. This enables cert-manager to complete HTTP01 challenges for the API endpoint (api.cluster.example.com) on baremetal platforms where DNS01 is not available. Key design decisions: - New HTTP01Proxy CRD in cert-manager-operator (not openshift/api) - Optional day-2 feature (not core payload) - Follows same pattern as istiocsrs.operator.openshift.io - DaemonSet on control plane nodes with nftables traffic redirection Supersedes: openshift#1773
Draft for adding an enhancement for the Cert Manager HTTP01 proxy.
Based on #1682 for inspiration. Thanks @swghosh for pointing me to that.
cc @mvazquezc