Skip to content

MCO-1533: Update MachineConfigNode Enhancement for 4.19 #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 9, 2025
Merged

MCO-1533: Update MachineConfigNode Enhancement for 4.19 #1765

openshift-merge-bot merged 1 commit into from
Jul 9, 2025

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Mar 11, 2025 •
edited
Loading

This updates the MCN enhancement to describe the functionality as it stands in 4.19. Some of the major changes included are:

  • Changes made to the MCN API resources & the introduction of a v1 API
  • Updates made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2025 •
edited by openshift-ci bot
Loading

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@isabella-janssen isabella-janssen mentioned this pull request Mar 11, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025 •
edited by openshift-ci bot
Loading

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This updates the MCN enhancement with:

  • Changes made to the API for GA
  • Updates that were made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen mentioned this pull request Apr 1, 2025
Merged
@openshift-bot
Copy link

openshift-bot commented May 2, 2025

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2025
@openshift-bot
Copy link

openshift-bot commented May 9, 2025

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2025
@openshift-bot
Copy link

openshift-bot commented May 17, 2025

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2025

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member Author

isabella-janssen commented May 22, 2025

/reopen

@openshift-ci openshift-ci bot reopened this May 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@isabella-janssen: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This updates the MCN enhancement with:

  • Changes made to the API for GA
  • Updates that were made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

isabella-janssen commented May 22, 2025

/remove-lifecycle stale

@isabella-janssen
Copy link
Member Author

isabella-janssen commented May 22, 2025

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 22, 2025
@isabella-janssen isabella-janssen marked this pull request as ready for review May 22, 2025 19:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2025
@openshift-ci openshift-ci bot requested review from Prashanth684 and tkashem May 22, 2025 19:08
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This updates the MCN enhancement with:

  • Changes made to the MCN API resources for GA
  • Updates that were made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen force-pushed the mcn-updates branch 2 times, most recently from 61a5338 to d6579f3 Compare June 10, 2025 17:44
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025 •
edited by openshift-ci bot
Loading

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This updates the MCN enhancement to describe the functionality as it stands in 4.19. Some of the major changes included are:

  • Changes made to the MCN API resources & the introduction of a v1 API
  • Updates made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pablintino
pablintino reviewed Jun 11, 2025
View reviewed changes
@isabella-janssen isabella-janssen mentioned this pull request Jun 12, 2025
Merged
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Jun 13, 2025

/skip

@isabella-janssen isabella-janssen force-pushed the mcn-updates branch 2 times, most recently from bda3e54 to 21a42bc Compare June 17, 2025 11:45
@isabella-janssen isabella-janssen changed the title MCO-1533: Update MachineConfigNode Enhancement MCO-1533: Update MachineConfigNode Enhancement for 4.19 Jun 23, 2025
@isabella-janssen
Copy link
Member Author

isabella-janssen commented Jun 23, 2025

/retest-required

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Jul 1, 2025

/retest-required

@pablintino
Copy link
Contributor

pablintino commented Jul 2, 2025

Looks good to me now. Great job updating this enhacement!
( I think I do not have permissions to /lgtm)

djoshy
djoshy reviewed Jul 2, 2025
View reviewed changes
enhancements/machine-config/machine-config-node.md Outdated
The MachineConfigDaemon (MCD) owns this datatype. Inside of the MCD there now is an "UpgradeMonitor" package which contains all of the logic to manage these MCN. Since the Daemon owns all code related to updates (outside of a few drain controller functions), the MachineConfigDaemon has full ownership over these new objects. During the process of an upgrade, the MachineConfigDaemon will call the upgrade monitor with key information related to OCP updates and it will update the spec and status of the MCNs.

The MachineConfigOperator pod will manage the rollout of the initial objects and the CRD for MachineConfigNodes. The MachineConfigOperator pod manages all manifests and resources which the operator owns, making this the best place for resource management of the MachineConfigNode to live.
The MachineConfigOperator pod will manage the rollout of the initial objects and the CRD for MCNs. The MachineConfigOperator pod manages all manifests and resources which the operator owns, making this the best place for resource management of the MCN to live.
Copy link
Contributor

@djoshy djoshy Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: This was the case when this EP was written, but the CRD now lives in the API repo and is deployed by the CVO.

Copy link
Member Author

@isabella-janssen isabella-janssen Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be updated, thanks for clarifying this!

djoshy
djoshy reviewed Jul 2, 2025
View reviewed changes
@djoshy
Copy link
Contributor

djoshy commented Jul 3, 2025

/lgtm

Looks good from my end, thanks for the fix-ups!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
yuqi-zhang
yuqi-zhang approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well, thanks for the updates!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a7a69cf into openshift:master Jul 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashanth684 Prashanth684 Awaiting requested review from Prashanth684

@tkashem tkashem Awaiting requested review from tkashem

3 more reviewers

@djoshy djoshy djoshy left review comments

@pablintino pablintino pablintino left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@djoshy djoshy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@isabella-janssen @openshift-ci-robot @openshift-bot @pablintino @djoshy @yuqi-zhang