USHIFT-4377: introduce microshift ingress performance enhancement #1685

eslutsky · 2024-09-23T13:20:32Z

No description provided.

openshift-ci · 2024-09-23T13:20:39Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2024-09-23T13:23:13Z

@eslutsky: This pull request references USHIFT-4377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ShaunaDiaz

Some Qs from the docs side, thank you!

enhancements/microshift/microshift-router-configuration-performance.md

ShaunaDiaz · 2024-10-02T19:15:21Z

enhancements/microshift/microshift-router-configuration-performance.md

+**cluster admin** is a human user responsible for configuring a MicroShift
+cluster.
+
+1. The cluster admin adds specific configuration for the router prior to


Is this an immutable configuration?
Can the user set it day 1 or day 2 after they've started MicroShift?

yes,its router runtime configuration it can be changed on day 2.

enhancements/microshift/microshift-router-configuration-performance.md

ShaunaDiaz · 2024-10-02T19:19:32Z

enhancements/microshift/microshift-router-configuration-performance.md

+## Graduation Criteria
+Targeting GA for MicroShift 4.18 release.
+
+### Dev Preview -> Tech Preview


Are we targeting Tech Preview in 4.18, or Dev?

ShaunaDiaz · 2024-10-02T19:20:36Z

enhancements/microshift/microshift-router-configuration-performance.md

+### Removing a deprecated feature
+N/A
+
+## Upgrade / Downgrade Strategy


Are these only for minor-version updates/downgrades? What about z-stream updates?

eslutsky · 2024-10-09T10:33:55Z

/test markdownlint

enhancements/microshift/microshift-router-configuration-performance.md

ShudiLi · 2024-11-04T02:22:14Z

lgtm, also did the compared test with the default-config.yaml file.

/label qe-approved
thanks

openshift-ci-robot · 2024-11-04T02:22:19Z

@eslutsky: This pull request references USHIFT-4377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jerpeter1 · 2024-11-11T19:53:34Z

enhancements/microshift/microshift-router-configuration-performance.md

+| new configuration                                 | description                                                                                                                                                                                     | default |
+| ------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
+| ingress.httpCompressionMimeTypes                  | list of MIME types that should have compression applied. <br>At least one MIME type must be specified.<br>                                                                                      | none    |
+| ingress.forwardedHeaderPolicy                     | specify when and how the Ingress Controller sets the `Forwarded`, `X-Forwarded-For`, `X-Forwarded-Host`, `X-Forwarded-Port`, `X-Forwarded-Proto`, and `X-Forwarded-Proto-Version` HTTP headers. | append  |


Not sure if it matters, but "Append" is capitalized (like "Log", and "Respond"), in the PR for this EP

jerpeter1 · 2024-11-11T20:05:19Z

Given that we're just enabling the configuration options available in openshift, this suggestion might be directed to the upstream docs, but I think the docs should probably describe what reasonable values are for ingress configuration options, what effects they'll have on e.g. memory footprint and connection interruptions, etc - I think it might be worth considering putting guardrails on these values depending on what comes out during testing - WDYT?

eslutsky · 2024-11-18T11:24:54Z

Given that we're just enabling the configuration options available in openshift, this suggestion might be directed to the upstream docs, but I think the docs should probably describe what reasonable values are for ingress configuration options, what effects they'll have on e.g. memory footprint and connection interruptions, etc - I think it might be worth considering putting guardrails on these values depending on what comes out during testing - WDYT?

yes, its something we can in the future, default configuration should provide the best ingress performance/pod memory consumption balance.

Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>

openshift-ci · 2024-11-18T11:58:28Z

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jerpeter1 · 2024-11-18T14:24:52Z

/lgtm
/approve

openshift-ci · 2024-11-18T14:25:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerpeter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jerpeter1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024

eslutsky changed the title ~~introduce microshift ingress performance enhancement~~ USHIFT-4377: introduce microshift ingress performance enhancement Sep 23, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024

eslutsky force-pushed the microshift-ingress-performance branch 3 times, most recently from 2b084b7 to 4b24145 Compare September 23, 2024 13:37

ShaunaDiaz reviewed Oct 2, 2024

View reviewed changes

eslutsky force-pushed the microshift-ingress-performance branch 16 times, most recently from cfccfa8 to bdf03cc Compare October 8, 2024 09:55

eslutsky marked this pull request as ready for review October 8, 2024 09:55

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024

openshift-ci bot requested review from bradmwilliams and sjenning October 8, 2024 09:56

eslutsky force-pushed the microshift-ingress-performance branch from bdf03cc to 45f4583 Compare October 8, 2024 13:22

eslutsky force-pushed the microshift-ingress-performance branch from 45f4583 to 866d4d6 Compare October 8, 2024 14:06

pacevedom reviewed Oct 9, 2024

View reviewed changes

eslutsky force-pushed the microshift-ingress-performance branch 2 times, most recently from 3f9ac05 to b4efa1f Compare October 10, 2024 13:19

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 4, 2024

eslutsky force-pushed the microshift-ingress-performance branch 2 times, most recently from 4ad95cf to 2ed1309 Compare November 4, 2024 13:55

jerpeter1 self-assigned this Nov 8, 2024

jerpeter1 reviewed Nov 11, 2024

View reviewed changes

USHIFT-4377: introduce microshift ingress performance enhancement

3c39fea

Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>

eslutsky force-pushed the microshift-ingress-performance branch from 2ed1309 to 3c39fea Compare November 18, 2024 11:26

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024

openshift-merge-bot bot merged commit 7accb68 into openshift:master Nov 18, 2024

USHIFT-4377: introduce microshift ingress performance enhancement #1685

USHIFT-4377: introduce microshift ingress performance enhancement #1685

Uh oh!

Conversation

eslutsky commented Sep 23, 2024

Uh oh!

openshift-ci bot commented Sep 23, 2024

Uh oh!

openshift-ci-robot commented Sep 23, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShaunaDiaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ShaunaDiaz Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

eslutsky Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ShaunaDiaz Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

ShaunaDiaz Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

eslutsky commented Oct 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShudiLi commented Nov 4, 2024

Uh oh!

openshift-ci-robot commented Nov 4, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerpeter1 Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

jerpeter1 commented Nov 11, 2024

Uh oh!

eslutsky commented Nov 18, 2024

Uh oh!

openshift-ci bot commented Nov 18, 2024

Uh oh!

jerpeter1 commented Nov 18, 2024

Uh oh!

openshift-ci bot commented Nov 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Sep 23, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 4, 2024 •

edited by openshift-ci bot

Loading