Performance-Tuning enhancement proposal.

[alanconway]

Covers delivery reliability (log loss) and sundry output tuning (reconnect, compression, batching)
I'm happy that this proposal is usable and outlines a feasible implementation.

[jcantrill]

While I don't wish to add a field for every vector tuning option, I don't think we can capture all tuning in the way described here. I believe we are really going need to allow a user to explicitly define a parameter like blocking behavior or max events. I don't see any option other then explicit tuning and we have customers who are already experiencing this short fall

[alanconway]

@jcantrill Great feedback, thanks. I'll have to do some re-writing to address it, see next push.

[alanconway]

@jcantrill @periklis please check if I've addressed your concerns.

[periklis]

LGTM

[dhellmann]

#1555 is changing the enhancement template in a way that will cause the header check in the linter job to fail for existing PRs. If this PR is merged within the development period for 4.16 you may override the linter if the only failures are caused by issues with the headers (please make sure the markdown formatting is correct). If this PR is not merged before 4.16 development closes, please update the enhancement to conform to the new template.

[alanconway]

Hopefully final draft: updated to be compatible with the v2 API proposal and @jcantrill PRs using AtLeastOnce/AtMostOnce instead of fast/safe. With the new terms, everything is easier to explain and I've re-directed the focus to reliability rather than performance which fixes some of @cahartma concerns. I've also added a "fallback" position to force use of persistence as suggested by @kattz-kawa.

[jcantrill]

/hold

[alanconway]

/retest

[alanconway]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• enhancements/cluster-logging/OWNERS [alanconway]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcantrill]

/hold cancel
/lgtm

[openshift-ci]

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.