enhancements/update/targeted-update-edge-blocking: Drop Evaluating#1420
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jun 7, 2023
Merged
enhancements/update/targeted-update-edge-blocking: Drop Evaluating#1420openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Following up on 6af8d09 (enhancements/update/targeted-update-edge-blocking: Update after API landed, 2021-09-20, openshift#910), with more changes to align this enhancement with the actual implementation. We never implemented Evaluating, because Recommended=Unknown means we're trying (and failing) to figure out if some of the target's risks apply to the cluster. And: // +kubebuilder:validation:Required // +kubebuilder:validation:MinItems=1 // +listType=atomic // +required MatchingRules []ClusterCondition `json:"matchingRules"` means that empty matchingRules is not possible, as previously discussed around: Mitigating that "where did that edge go?" confusion in the required-property alternative, David expects graph-admins to be keeping watch over enough ClusterVersion content... in the alternatives section of the enhancement.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wking
added a commit
to wking/openshift-api
that referenced
this pull request
Feb 6, 2024
…conditionalUpdates condition type Catching up with openshift/enhancements@c446cd7846 (enhancements/update/targeted-update-edge-blocking: Drop Evaluating, 2023-06-07, openshift/enhancements#1420), which points out that this type was never implemented, because Recommended=Unknown is sufficient to say "we're trying (and failing) to figure out if some of the target's risks apply to the cluster".
wking
added a commit
to wking/openshift-api
that referenced
this pull request
Feb 6, 2024
…conditionalUpdates condition type Catching up with openshift/enhancements@c446cd7846 (enhancements/update/targeted-update-edge-blocking: Drop Evaluating, 2023-06-07, openshift/enhancements#1420), which points out that this type was never implemented, because Recommended=Unknown is sufficient to say "we're trying (and failing) to figure out if some of the target's risks apply to the cluster".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on 6af8d09 (#910), with more changes to align this enhancement with the actual implementation.
We never implemented
Evaluating, becauseRecommended=Unknownmeans we're trying (and failing) to figure out if some of the target's risks apply to the cluster.And:
means that empty
matchingRulesis not possible, as previously discussed around:in the alternatives section of the enhancement.